xds: remove temporary environment variable for least request

[atollena]

Fixes #8228.

RELEASE NOTES:

• Remove the GRPC_EXPERIMENTAL_ENABLE_LEAST_REQUEST environment variable that allows disabling the least request balancer with xDS. Least request was made available by default with xDS in v1.72.0.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.20%. Comparing base (9319d72) to head (27110de).
Report is 1 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #8248      +/-   ##
==========================================
- Coverage   82.33%   82.20%   -0.14%     
==========================================
  Files         419      419              
  Lines       42068    42065       -3     
==========================================
- Hits        34638    34580      -58     
- Misses       5979     6014      +35     
- Partials     1451     1471      +20     

Files with missing lines	Coverage Δ
internal/envconfig/envconfig.go	100.00% <ø> (ø)
...nal/xdsclient/xdslbregistry/converter/converter.go	70.00% <ø> (-0.63%)	⬇️
...ds/internal/xdsclient/xdsresource/unmarshal_cds.go	86.72% <ø> (+0.64%)	⬆️

... and 30 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[atollena]

As discussed I'll keep this PR for later and work on a change that just flips the environment variable default to true.

[arjan-bal]

@dfawley is it sufficient for one minor version (1.72) to have the flag defaulted to true before removing the env var completely? If yes, we can review and merge this.

[dfawley]

In this particular case, I think it's fine. I am not really concerned that registering this LB policy by default is going to cause problems. For other things that might be more risky, because we know our users don't always upgrade in a timely fashion, I think it's better to wait at least 2-3 releases before removing the flag.

[dfawley]

@atollena can you please take a look at the merge conflicts? Thanks!

[dfawley]

@arjan-bal please do a second review & approve.

[arjan-bal]

I re-checked and found that 1.72.0 doesn't have #8253 that sets the default to true. So we need to wait for #8253 to be released with 1.73 and remove the env var in 1.74.

[atollena]

I re-checked and found that 1.72.0 doesn't have #8253 that sets the default to true. So we need to wait for #8253 to be released with 1.73 and remove the env var in 1.74.

Sounds good to me, I'll resume this when 1.73 has been released.