Skip to content

grpc: add new Dial/ServerOptions to set the size like the existing ones, but which do not also disable BDP estimation #8279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

janardhanvissa
Copy link
Contributor

No description provided.

Copy link

codecov bot commented Apr 30, 2025

Codecov Report

Attention: Patch coverage is 62.50000% with 12 lines in your changes missing coverage. Please review.

Project coverage is 82.16%. Comparing base (54e7e26) to head (6937383).
Report is 12 commits behind head on master.

Files with missing lines Patch % Lines
internal/transport/http2_client.go 0.00% 2 Missing and 4 partials ⚠️
internal/transport/http2_server.go 0.00% 2 Missing and 4 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8279      +/-   ##
==========================================
+ Coverage   82.05%   82.16%   +0.10%     
==========================================
  Files         412      417       +5     
  Lines       40477    41413     +936     
==========================================
+ Hits        33213    34026     +813     
- Misses       5896     5947      +51     
- Partials     1368     1440      +72     
Files with missing lines Coverage Δ
dialoptions.go 91.15% <100.00%> (+0.35%) ⬆️
internal/transport/transport.go 91.56% <ø> (+6.82%) ⬆️
server.go 82.72% <100.00%> (+0.05%) ⬆️
internal/transport/http2_client.go 91.94% <0.00%> (-0.14%) ⬇️
internal/transport/http2_server.go 90.85% <0.00%> (-0.24%) ⬇️

... and 54 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@janardhanvissa janardhanvissa changed the title grpc: add new Dial/ServerOptions to set the size like the existing ones, but which do not also disable BDP esimation grpc: add new Dial/ServerOptions to set the size like the existing ones, but which do not also disable BDP estimation May 2, 2025
@arjan-bal
Copy link
Contributor

Closing in favour of #8283.

@arjan-bal arjan-bal closed this May 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants