Skip to content

Cherry-pick #8329 to v1.73.x #8354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 23, 2025

Conversation

eshitachandwani
Copy link
Member

@eshitachandwani eshitachandwani commented May 23, 2025

Original PR: #8329
Related Issue: #8327

RELEASE NOTES:

  • client: restore support for NO_PROXY environment variable when connecting to locally-resolved addresses. This fixes a regression and restores historical grpc-go behavior (use case 2 from gRFC A1 ).

Copy link

codecov bot commented May 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.23%. Comparing base (96c4308) to head (3429088).
Report is 1 commits behind head on v1.73.x.

Additional details and impacted files
@@             Coverage Diff             @@
##           v1.73.x    #8354      +/-   ##
===========================================
+ Coverage    82.11%   82.23%   +0.11%     
===========================================
  Files          419      419              
  Lines        42001    42015      +14     
===========================================
+ Hits         34490    34551      +61     
+ Misses        6038     6000      -38     
+ Partials      1473     1464       -9     
Files with missing lines Coverage Δ
.../resolver/delegatingresolver/delegatingresolver.go 86.42% <100.00%> (+0.91%) ⬆️

... and 25 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@eshitachandwani eshitachandwani self-assigned this May 23, 2025
@eshitachandwani eshitachandwani merged commit b610465 into grpc:v1.73.x May 23, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants