Skip to content

examples/opentelemetry: demonstrate enabling experimental metrics #8388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jun 23, 2025
Merged

examples/opentelemetry: demonstrate enabling experimental metrics #8388

merged 5 commits into from
Jun 23, 2025
+49 −6

Conversation

vinothkumarr227
Copy link
Contributor

@vinothkumarr227 vinothkumarr227 commented Jun 9, 2025 •
edited by arjan-bal
Loading

Fixes #8311

RELEASE NOTES:

  • examples: Add examples to demonstrate enabling experimental metrics using the opentelemetry plugin.

@codecov Codecov
Copy link

codecov bot commented Jun 9, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.31%. Comparing base (e5de1e2) to head (cd4419b).
Report is 3 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #8388      +/-   ##
==========================================
- Coverage   82.33%   82.31%   -0.03%     
==========================================
  Files         413      413              
  Lines       40454    40430      -24     
==========================================
- Hits        33307    33278      -29     
+ Misses       5782     5779       -3     
- Partials     1365     1373       +8

see 20 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

arjan-bal
arjan-bal reviewed Jun 16, 2025
View reviewed changes
@vinothkumarr227 vinothkumarr227 removed their assignment Jun 17, 2025
arjan-bal
arjan-bal reviewed Jun 18, 2025
View reviewed changes
@vinothkumarr227 vinothkumarr227 removed their assignment Jun 18, 2025
@arjan-bal arjan-bal changed the title stats: Update documentation and examples to demonstrate enabling experimental metrics examples/opentelemetry: Demonstrate enabling experimental metrics Jun 19, 2025
@arjan-bal arjan-bal changed the title examples/opentelemetry: Demonstrate enabling experimental metrics examples/opentelemetry: demonstrate enabling experimental metrics Jun 19, 2025
@arjan-bal
Copy link
Contributor

Please merge the latest master branch to unblock the PR Validation test.

@arjan-bal arjan-bal added the Type: Documentation Documentation or examples label Jun 19, 2025
@arjan-bal arjan-bal added this to the 1.74 Release milestone Jun 19, 2025
@arjan-bal
Copy link
Contributor

arjan-bal commented Jun 19, 2025 •
edited
Loading

The merge is not performed correctly. The PR diff is showing all the commits that were merged. Can you please reset and do a regular git merge origin/master?

@vinothkumarr227 vinothkumarr227 force-pushed the update-opentelemetry-examples branch from 0243437 to e5de1e2 Compare June 19, 2025 06:23
@vinothkumarr227
Copy link
Contributor Author

@arjan-bal I force-pushed after merging the latest master, and it seems the branch got closed automatically. Can you able to open this branch.

@arjan-bal
Copy link
Contributor

There are 0 commits on the PR, so it can't be re-opened. If you can bring back the commits on this branch, I should be able to re-open it.

@vinothkumarr227 vinothkumarr227 force-pushed the update-opentelemetry-examples branch 3 times, most recently from 0ea97fb to db6900c Compare June 19, 2025 08:27
@vinothkumarr227 vinothkumarr227 force-pushed the update-opentelemetry-examples branch from db6900c to 5143e0d Compare June 19, 2025 08:27
@vinothkumarr227 vinothkumarr227 force-pushed the update-opentelemetry-examples branch from 5143e0d to d2e8366 Compare June 19, 2025 08:27
@vinothkumarr227 vinothkumarr227 removed their assignment Jun 19, 2025
arjan-bal
arjan-bal reviewed Jun 20, 2025
View reviewed changes
examples/features/opentelemetry/client/main.go Outdated
Comment on lines 65 to 67
// These are example experimental gRPC metrics, which are disabled by default
// and must be explicitly enabled. For the full, up-to-date list of metrics,
// see: https://grpc.io/docs/guides/opentelemetry-metrics/#instruments
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please move these comments to the line just above Metrics: .

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@vinothkumarr227 vinothkumarr227 removed their assignment Jun 20, 2025
@arjan-bal arjan-bal merged commit bdbe6a2 into grpc:master Jun 23, 2025
16 checks passed
purnesh42H
purnesh42H reviewed Jun 23, 2025
View reviewed changes
examples/features/opentelemetry/server/main.go
// up-to-date list of metrics, see:
// https://grpc.io/docs/guides/opentelemetry-metrics/#instruments
Metrics: opentelemetry.DefaultMetrics().Add(
"grpc.server.call.started",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why are we adding these in default? These are already part of default metric set

grpc-go/stats/opentelemetry/opentelemetry.go

Line 443 in bdbe6a2

defaultPerCallMetrics = stats.NewMetricSet(ClientAttemptStartedMetricName, ClientAttemptDurationMetricName, ClientAttemptSentCompressedTotalMessageSizeMetricName, ClientAttemptRcvdCompressedTotalMessageSizeMetricName, ClientCallDurationMetricName, ServerCallStartedMetricName, ServerCallSentCompressedTotalMessageSizeMetricName, ServerCallRcvdCompressedTotalMessageSizeMetricName, ServerCallDurationMetricName)
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@purnesh42H purnesh42H purnesh42H left review comments

@arjan-bal arjan-bal arjan-bal approved these changes

Assignees
No one assigned
Labels
Type: Documentation Documentation or examples
Projects
None yet
Milestone
1.74 Release
Development

Successfully merging this pull request may close these issues.

stats: Update documentation and examples to demonstrate enabling experimental metrics
3 participants
@vinothkumarr227 @arjan-bal @purnesh42H