Rollforward xdsclient migrate internal

[purnesh42H]

This reverts commit d2e8366 and fix the content-type for generic grpc transport.

RELEASE NOTES: None

[codecov]

Codecov Report

Attention: Patch coverage is 81.90184% with 59 lines in your changes missing coverage. Please review.

Project coverage is 82.32%. Comparing base (5f8fe4f) to head (0bb99e8).
Report is 1 commits behind head on master.

Files with missing lines	Patch %	Lines
...ds/internal/xdsclient/xdsresource/resource_type.go	58.00%	15 Missing and 6 partials ⚠️
xds/internal/xdsclient/clientimpl.go	88.79%	7 Missing and 6 partials ⚠️
xds/internal/xdsclient/pool.go	81.25%	4 Missing and 2 partials ⚠️
...nal/clients/xdsclient/internal/xdsresource/type.go	54.54%	5 Missing ⚠️
xds/internal/xdsclient/clientimpl_loadreport.go	76.19%	4 Missing and 1 partial ⚠️
xds/internal/clients/xdsclient/channel.go	57.14%	2 Missing and 1 partial ⚠️
xds/internal/internal.go	66.66%	3 Missing ⚠️
.../internal/balancer/loadstore/load_store_wrapper.go	84.61%	2 Missing ⚠️
xds/internal/testutils/fakeclient/client.go	94.44%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #8391      +/-   ##
==========================================
+ Coverage   82.25%   82.32%   +0.06%     
==========================================
  Files         419      413       -6     
  Lines       42069    40454    -1615     
==========================================
- Hits        34604    33303    -1301     
+ Misses       6008     5778     -230     
+ Partials     1457     1373      -84     

Files with missing lines	Coverage Δ
internal/xds/bootstrap/bootstrap.go	65.35% <100.00%> (-0.38%)	⬇️
xds/internal/balancer/clusterimpl/clusterimpl.go	90.24% <100.00%> (+0.24%)	⬆️
xds/internal/balancer/clusterimpl/picker.go	100.00% <100.00%> (ø)
...internal/balancer/clusterresolver/configbuilder.go	92.85% <100.00%> (ø)
...alancer/clusterresolver/configbuilder_childname.go	100.00% <100.00%> (ø)
xds/internal/balancer/wrrlocality/balancer.go	68.81% <100.00%> (ø)
...s/internal/clients/grpctransport/grpc_transport.go	89.81% <100.00%> (ø)
xds/internal/clients/lrsclient/load_store.go	93.19% <100.00%> (ø)
xds/internal/clients/lrsclient/lrs_stream.go	68.50% <100.00%> (-3.22%)	⬇️
xds/internal/xdsclient/client.go	100.00% <ø> (ø)
... and 15 more

... and 25 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[arjan-bal]

Can you please check if the failure is related to this PR?

server_resource_ext_test.go:268: unexpected connectivity state change {READY --> CONNECTING} on the client connection

[arjan-bal]

Would let @easwars approve since he may need to rebase #8389 based on the order or merging the PRs.

[purnesh42H]

Can you please check if the failure is related to this PR?

server_resource_ext_test.go:268: unexpected connectivity state change {READY --> CONNECTING} on the client connection

Seems like a flake? content-type change should not be related. Filed an issue #8392

[arjan-bal]

Can you please check if the failure is related to this PR?

server_resource_ext_test.go:268: unexpected connectivity state change {READY --> CONNECTING} on the client connection

Seems like a flake? content-type change should not be related. Filed an issue #8392

This could be related to migration changes that are being rolled forward. I'm fine with moving ahead with the test failure, as long as we are confident that the test also flakes on master.

[arjan-bal]

Please verify that the flaking test is not due to this PR before merging.

[easwars]

server_resource_ext_test.go:268: unexpected connectivity state change {READY --> CONNECTING} on the client connection

My change is small. So, I will wait for this to go in and I will resolve any conflicts and merge later. Thanks.

[easwars]

The dependecy changes test is failing. @dfawley and I had looked at it previously. @purnesh42H : You should be using the status code from the grpc package and not from "google.golang.org/genproto/googleapis/rpc/code". Please fix that before merging, and ensure that the dependency changes test is passing.

[purnesh42H]

The dependecy changes test is failing. @dfawley and I had looked at it previously. @purnesh42H : You should be using the status code from the grpc package and not from "google.golang.org/genproto/googleapis/rpc/code". Please fix that before merging, and ensure that the dependency changes test is passing.

Actually, we decided to keep it because we shouldn't be having grpc packages in core modules #8310 (comment).

[arjan-bal]

Verified on forge that the flaking test fails a couple of times in 100k runs on both master and this PR. This indicates that the flake may not be a regresion.

[arjan-bal]

Mergeable seems stuck.