Skip to content

xds_test: Avoid buffering ack requests in ADS streams #8395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 16, 2025

Conversation

arjan-bal
Copy link
Contributor

@arjan-bal arjan-bal commented Jun 12, 2025

Fixes: #8185

The test stores listener names in a buffered channel with capacity 1. The test generates 3 listener request messages:

  1. Subscribe to resource.
  2. ACK initial update.
  3. ACK update after the route is updated in the management server.

Only one read happens from the channel. If we attempt to store the 3rd update in the channel, the xDS management server will get blocked.

Verified that test doesn't fail in 100k runs on forge.

RELEASE NOTES: N/A

@easwars easwars assigned arjan-bal and unassigned easwars Jun 12, 2025
Copy link

codecov bot commented Jun 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.36%. Comparing base (082a927) to head (42927b4).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8395      +/-   ##
==========================================
+ Coverage   82.28%   82.36%   +0.07%     
==========================================
  Files         413      413              
  Lines       40454    40454              
==========================================
+ Hits        33289    33318      +29     
+ Misses       5795     5772      -23     
+ Partials     1370     1364       -6     

see 21 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@arjan-bal arjan-bal merged commit 042139c into grpc:master Jun 16, 2025
15 checks passed
vinothkumarr227 pushed a commit to vinothkumarr227/grpc-go that referenced this pull request Jun 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flaky test: Test/Server_Basic
2 participants