Skip to content

xds: Fix flaky test HandleListenerUpdate_ErrorUpdate #8397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 16, 2025

Conversation

arjan-bal
Copy link
Contributor

Fixes: #8305

After #7977 the server's serving mode started being updated to NOT_SERVING every time a listener resource is NACKed. During the test, the xDS management server replies with the same resource version if a after client NACKs a resource. The test registers a callback that pushes the serving mode state updates to a buffered channel of size 1. The channel gets filled and blocks the test indefinitely.

This PR ensures we only keep the latest serving mode in the channel to avoid deadlocks. Verified that the test doesn't flake in 100k runs on forge.

RELEASE NOTES: N/A

Copy link

codecov bot commented Jun 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.37%. Comparing base (082a927) to head (5e063ba).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8397      +/-   ##
==========================================
+ Coverage   82.28%   82.37%   +0.08%     
==========================================
  Files         413      413              
  Lines       40454    40454              
==========================================
+ Hits        33289    33322      +33     
+ Misses       5795     5766      -29     
+ Partials     1370     1366       -4     

see 21 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@arjan-bal arjan-bal added this to the 1.74 Release milestone Jun 16, 2025
@arjan-bal arjan-bal merged commit 9c62b1c into grpc:master Jun 16, 2025
15 of 16 checks passed
@arjan-bal arjan-bal deleted the fix-listener-error-test branch June 16, 2025 18:53
vinothkumarr227 pushed a commit to vinothkumarr227/grpc-go that referenced this pull request Jun 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flaky Test: Test/HandleListenerUpdate_ErrorUpdate
2 participants