xds: Fix flaky test HandleListenerUpdate_ErrorUpdate #8397
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #8305
After #7977 the server's serving mode started being updated to NOT_SERVING every time a listener resource is NACKed. During the test, the xDS management server replies with the same resource version if a after client NACKs a resource. The test registers a callback that pushes the serving mode state updates to a buffered channel of size 1. The channel gets filled and blocks the test indefinitely.
This PR ensures we only keep the latest serving mode in the channel to avoid deadlocks. Verified that the test doesn't flake in 100k runs on forge.
RELEASE NOTES: N/A