outlierdetection: cleanup temporary pickfirst health listener attribute #8402
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arjan-bal
force-pushed
the
outlier-detection-cleanup
branch
from
e5bc491 to
c361f98
Compare
arjan-bal
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8402 +/- ##
==========================================
+ Coverage 82.28% 82.42% +0.13%
==========================================
Files 413 413
Lines 40454 40430 -24
==========================================
+ Hits 33289 33324 +35
+ Misses 5795 5748 -47
+ Partials 1370 1358 -12
🚀 New features to boost your workflow:
|
easwars
approved these changes
Jun 18, 2025
| // pick_first and outlier detection will only use the health listener for | ||
| // ejection. This hack can then be removed. | ||
| func IsManagedByPickfirst(addr resolver.Address) bool { | ||
| return addr.BalancerAttributes.Value(managedByPickfirstKeyType{}) != nil |
There was a problem hiding this comment.
I see that the type managedByPickfirstKeyType is not deleted. Nor is the code to set this attribute from newSCData. Any reason we still need them?
There was a problem hiding this comment.
Nice catch, I forgot to clean it up. Removed now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #7915
During the implementation of dualstack changes, OutlierDetection needed to handle ejection of subchannels using both the connectivity listener and the new health listener. Now that all Petiole LB policies used in xDS delegate to pick_first, OutlierDetection only needs to support ejection through the health listener. The old code for ejection via the connectivity listener has been cleaned up.
RELEASE NOTES: N/A