Skip to content

xdsclient: make a function to return the supported resource type implementations #8405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 24, 2025

Conversation

easwars
Copy link
Contributor

@easwars easwars commented Jun 24, 2025

This change will make it possible to use a different set of resource type implementations in other deployments by conditionally replacing this function with another one.

RELEASE NOTES: none

@easwars easwars requested a review from arjan-bal June 24, 2025 05:37
@easwars easwars added the Type: Internal Cleanup Refactors, etc label Jun 24, 2025
@easwars easwars added this to the 1.74 Release milestone Jun 24, 2025
Copy link

codecov bot commented Jun 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.32%. Comparing base (20bd1e7) to head (c5fbf28).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8405      +/-   ##
==========================================
- Coverage   82.44%   82.32%   -0.13%     
==========================================
  Files         413      414       +1     
  Lines       40424    40420       -4     
==========================================
- Hits        33328    33275      -53     
- Misses       5742     5774      +32     
- Partials     1354     1371      +17     
Files with missing lines Coverage Δ
xds/internal/xdsclient/clientimpl.go 82.52% <100.00%> (-4.05%) ⬇️
xds/internal/xdsclient/resource_types.go 100.00% <100.00%> (ø)

... and 23 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@arjan-bal arjan-bal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arjan-bal arjan-bal assigned easwars and unassigned arjan-bal Jun 24, 2025
@easwars easwars merged commit 15299cc into grpc:master Jun 24, 2025
16 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants