rust: add safe keyword
#4292
Open
rust: add safe keyword
#4292
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshgoebel
reviewed
Jul 3, 2025
|
We'd also need a markup test to show what this syntax looks like in real life and guarantee that your rule is working as intended and that there are no edge cases, etc we need to concern ourselves with. |
Co-authored-by: Josh Goebel <me@joshgoebel.com>
This is a "weak" keyword, only applicable in Rust 2024+ `unsafe extern` blocks, immediately prior to the "extern" keyword: https://doc.rust-lang.org/reference/keywords.html#r-lex.keywords.weak.safe
|
I added a test, resulting in an alternative approach that should be more foolproof. Let me know what else is needed, if anything. |
Yang062
approved these changes
Jul 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a "weak" keyword, only applicable in Rust 2024+
unsafe externblocks: https://doc.rust-lang.org/reference/keywords.html#r-lex.keywords.weak.safeChanges
Adds the
safekeyword within a mode forunsafe externblocks.Checklist
CHANGES.md