Add single file support #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamesjarvis
reviewed
Aug 17, 2021
examplerepo/go.mod
Outdated
| @@ -0,0 +1,6 @@ | |||
| module easteregg | |||
There was a problem hiding this comment.
why is this file being committed? it's supposed to be a temporary file
| } | ||
| buildDir = fmt.Sprintf("third_party/go/%s", pathMinusEnd) | ||
| } else { | ||
| buildDir = "third_party/go" |
There was a problem hiding this comment.
think this would be neater if we just instantiated buildDir := "third_party/go" and then modified it if not single file build?
| } | ||
| buildDir = fmt.Sprintf("third_party/go/%s", pathMinusEnd) | ||
| } else { | ||
| buildDir = "third_party/go" |
| @@ -238,6 +251,12 @@ func (vd *VersionDirectory) SetVersion(version string, mod *Module) *Module { | |||
| // If incoming is less than existing, return existing. | |||
| return existingMod | |||
| } | |||
| if major == "v1" && existingMajor == "v0" { | |||
| delete(vd.versions, existingVers) | |||
| vd.versions[version] = mod | |||
There was a problem hiding this comment.
wouldn't we then want to return mod here?
module/directory.go
Outdated
| @@ -33,10 +33,16 @@ func NewDirectory() *Directory { | |||
|
|
|||
| // Sync is a lazy implementation to refresh all of the module dependencies to the closest semver. | |||
| func (d *Directory) Sync() { | |||
| names := make(map[string]bool, 0) | |||
There was a problem hiding this comment.
as a nit, for these maps which are only use to check if a key has been "seen", it's generally better practice to have it be map[string]struct{} as then you don't need to worry about what the value is, just whether or not the key exists.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.