Skip to content

replace os family container arg with cm flag #497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 24, 2025

Conversation

estela-ramirez
Copy link
Contributor

@estela-ramirez estela-ramirez commented Jun 23, 2025

What type of PR is this?

  • Bug fix (non-breaking change which fixes an issue)
  • Feature/Enhancement (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Refactoring (no functional changes)
  • Performance improvement
  • Test updates
  • CI/CD related changes
  • Dependency upgrade

Description

Fixes bug where instance-manager would create 2 launch templates for an IG when upgrading to different amazon linux os family

Related issue(s)

High-level overview of changes

Testing performed

dev cluster
Screenshot 2025-06-24 at 10 06 24 AM

Checklist

  • I've read the CONTRIBUTING doc
  • I've added/updated tests that prove my fix is effective or that my feature works
  • I've added necessary documentation (if appropriate)
  • I've run make test locally and all tests pass
  • I've signed-off my commits with git commit -s for DCO verification
  • I've updated any relevant documentation
  • Code follows the style guidelines of this project

Additional information

@estela-ramirez estela-ramirez requested review from a team as code owners June 23, 2025 07:46
@estela-ramirez estela-ramirez marked this pull request as draft June 23, 2025 07:46
@codecov-commenter
Copy link

codecov-commenter commented Jun 23, 2025

Codecov Report

Attention: Patch coverage is 63.33333% with 11 lines in your changes missing coverage. Please review.

Project coverage is 46.57%. Comparing base (8188aaf) to head (fcfa7f1).

Files with missing lines Patch % Lines
controllers/reconcilers.go 0.00% 7 Missing ⚠️
controllers/provisioners/eks/eks.go 78.94% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #497      +/-   ##
==========================================
+ Coverage   46.48%   46.57%   +0.08%     
==========================================
  Files          40       40              
  Lines        7075     7094      +19     
==========================================
+ Hits         3289     3304      +15     
- Misses       3627     3632       +5     
+ Partials      159      158       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@estela-ramirez estela-ramirez force-pushed the remove-os-family-arg branch 3 times, most recently from 72c85c9 to 44236bd Compare June 24, 2025 04:54
@estela-ramirez estela-ramirez marked this pull request as ready for review June 24, 2025 17:01
Signed-off-by: eramirez8 <estela_ramirez@intuit.com>
Copy link

@kevdowney kevdowney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vgunapati vgunapati merged commit 37a9535 into keikoproj:master Jun 24, 2025
7 checks passed
@estela-ramirez estela-ramirez deleted the remove-os-family-arg branch June 24, 2025 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants