-
Notifications
You must be signed in to change notification settings - Fork 418
frontend: AlertNotification: Update Storybook with new stories #3365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!!!
@skoeva can u please review this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the last 2 commits can be squashed, would be nice to do that with a rebase too
The cases in the third and fourth screenshots don't represent real states of the AlertNotification component, those should be updated to more closely resemble the first and second screenshots
Sure. I'll do that |
Hi! Are you still planning on wrapping this PR up, or would you like someone else to take it over? |
Hi, sry for the delay on my part and I will get this done. |
a4e6ff5
to
2f861d9
Compare
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
2f861d9
to
f05d25a
Compare
d21d21d
to
f0a3f05
Compare
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ANIRUDH-SJ, ashu8912 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @skoeva i have the made the changes here in #3538 (comment) |
Updated the Storybook for AlertNotification and created new stories.