-
Notifications
You must be signed in to change notification settings - Fork 390
frontend: expand crs on sidebar #3366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: farodin91 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@illume I would like to get feedback. |
Some tests are expected to fail, until i known its going in the right direction. |
Hii @farodin91 thanks for these changes, I have tried the PR and would like to add a comment.
|
@ashu8912 As long as there is no plugin, I think it makes the CRDs more usable. I had this feature in Lens and I miss it in Headlamp. Improvement ideas
|
Very cool. A fix for this has been requested by a few people... One issue is here (with quite a few thumbs up from people): The difference in the issue is, they are asking for a collapsible menu in the page. |
I don't see a difference to the issue. Where do you see the difference? |
@farodin91 I thought they were suggesting putting the table on the page, vs the sidebar? |
Okay. In Openlens is it in sidebar. |
Can I see a full screenshot of the table of contents (sidebar) and the page for scenario where there might be a lot of CRs? The small picture doesn't make it clear for me to see the scale of the impact. |
6989ded
to
d977cd8
Compare
just a reminder that in the current sidebar implementation we also have tabs when sidebar is collapsed that don't support nesting |
@sniok I will fix it for this view. |
c1c16e5
to
bb93978
Compare
@sniok Multi layer navigation tabs are added. |
920adb1
to
94d84f1
Compare
94d84f1
to
da76b79
Compare
da76b79
to
4f6b727
Compare
@illume would you like to review? |
multiple tab layers with horizontal scrolling is not a good UX, it was considered before but decided against it |
@sniok Do you have a better idea? |
Signed-off-by: farodin91 <github@jan-jansen.net>
4d339c0
to
8e8a00b
Compare
Idea to make CRs more accessible: