Skip to content

frontend: Statefulset: Add storybook story #3413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 3, 2025
Merged

frontend: Statefulset: Add storybook story #3413

merged 1 commit into from
Jul 3, 2025

Conversation

SinghaAnirban005
Copy link
Contributor

Summary

This PR adds storybook story for components/statefulset component

Fixes #3411

Screenshots

For Details

  1. Default
    Screenshot from 2025-05-31 22-24-44

  2. With On Delete Strategy
    Screenshot from 2025-05-31 22-25-36

  3. With Multiple Containers
    Screenshot from 2025-05-31 22-26-11

  4. With complex selector
    Screenshot from 2025-05-31 22-25-52

For Lists

  1. Default
    Screenshot from 2025-05-31 22-26-35

  2. Empty List
    Screenshot from 2025-05-31 22-26-41

  3. Single Item
    Screenshot from 2025-05-31 22-26-45

  4. With Not Ready Replicas
    Screenshot from 2025-05-31 22-26-50

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 31, 2025
@k8s-ci-robot k8s-ci-robot requested review from skoeva and yolossn May 31, 2025 17:42
@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label May 31, 2025
skoeva
skoeva reviewed Jun 26, 2025
View reviewed changes
Copy link
Contributor

@skoeva skoeva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks solid! Could you squash the additional commits into one atomic commit?

@SinghaAnirban005 SinghaAnirban005 requested a review from skoeva June 27, 2025 06:51
skoeva
skoeva approved these changes Jun 27, 2025
View reviewed changes
Copy link
Contributor

@skoeva skoeva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

illume
illume approved these changes Jul 3, 2025
View reviewed changes
Copy link
Contributor

@illume illume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, solid work. 🎉 thanks

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: illume, SinghaAnirban005, skoeva

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 3, 2025
@illume illume merged commit 31fbe35 into kubernetes-sigs:main Jul 3, 2025
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@illume illume

@skoeva skoeva

@yolossn yolossn

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
Headlamp Release Plan / Roadmap
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

frontend: statefulset: Add Missing Storybook Stories
4 participants
@SinghaAnirban005 @k8s-ci-robot @illume @skoeva