Skip to content

headlamp-plugin: Fix exports registerKubeObjectGlance ConfigStore #3496

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 3, 2025
Merged

headlamp-plugin: Fix exports registerKubeObjectGlance ConfigStore #3496

merged 1 commit into from
Jul 3, 2025

Conversation

illume
Copy link
Contributor

@illume illume commented Jun 18, 2025 •
edited
Loading

registerKubeObjectGlance, ConfigStore, and registerUIPanel can be imported in plugins again.

Put this into a plugin, and do npm run tsc... there should be no error.

import { registerUIPanel, ConfigStore, registerKubeObjectGlance } from '@kinvolk/headlamp-plugin/lib';
console.log(registerUIPanel, ConfigStore, registerKubeObjectGlance);

fixes #3426

Related:

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jun 18, 2025
@k8s-ci-robot k8s-ci-robot requested review from ashu8912 and skoeva June 18, 2025 11:24
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 18, 2025
@illume illume added kind/bug Categorizes issue or PR as related to a bug. regression Bugs for things that used to work in previous releases. headlamp-plugin Related to the headlamp-plugin NPM package. labels Jun 18, 2025
@illume illume marked this pull request as ready for review June 18, 2025 11:53
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 18, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: illume, skoeva

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@illume illume merged commit 59bd90b into kubernetes-sigs:main Jul 3, 2025
11 of 12 checks passed
@illume illume deleted the hp-exports branch July 3, 2025 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skoeva skoeva

@ashu8912 ashu8912

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. headlamp-plugin Related to the headlamp-plugin NPM package. kind/bug Categorizes issue or PR as related to a bug. regression Bugs for things that used to work in previous releases. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
Headlamp Release Plan / Roadmap
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

plugins: Missing type for ConfigStore
3 participants
@illume @k8s-ci-robot @skoeva