-
Notifications
You must be signed in to change notification settings - Fork 194
Add missing dependencies #3364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Add missing dependencies #3364
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: dfajmon The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Welcome @dfajmon! |
Hi @dfajmon. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
When using `go list -mod=readonly -m all` the command fails on k8s.io/endpointslice and k8s.io/externaljwt as they are part of kubernetes.
/ok-to-test |
What this PR does / why we need it:
When using
go list -mod=readonly -m all
the command fails on k8s.io/endpointslice and k8s.io/externaljwt as they are part of kubernetes.Testing done:
Tested with
go list -mod=readonly -m all
returns non-zero output with list of dependencies.Special notes for your reviewer:
This has been investigated when rebasing for OpenShift, we are making sure we can compile the driver offline which means we need all dependencies mentioned in
go.mod
.Release note: