-
Notifications
You must be signed in to change notification settings - Fork 5.3k
Introduce Node Lifecycle WG #8396
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
/hold |
Looks like I'm not a member of kubernetes org anymore. I was a few years back, but didn't keep up with contributions recently. You can remove me as a lead and I can reapply after some contributions to this WG. |
75e1096
to
a19a192
Compare
We have had impactful conversations with Ryan about this group and its goals. He has experience with cluster maintenance and I look forward to his participation in the WG. |
/cc |
a19a192
to
2d6ac13
Compare
3aed2af
to
39e3bde
Compare
f920fdf
to
ddcdc26
Compare
I think we finally have all SIG +1s now? This group will have a lot to do :-) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
/hold
to get sufficient majority from steering
* Humble Chirammal (**[@humblec](https://github.com/humblec)**), VMware | ||
* Lucy Sweet (**[@intUnderflow](https://github.com/intUnderflow)**), Uber | ||
* Krzysztof Wilczyński (**[@kwilczynski](https://github.com/kwilczynski)**), Independent | ||
* Ryan Hallisey (**[@rthallisey](https://github.com/rthallisey)**), NVIDIA |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Being a lead is a certain responsibility. It goes beyond "is interested in the topic". But I'm okay with letting you figure out among yourself who is really showing up consistently to keep the WG moving and then perhaps do some pruning.
wg-node-lifecycle/charter.md
Outdated
## Timelines and Disbanding | ||
|
||
The working group will disband once the features and core APIs defined in the following | ||
KEPs/Features have reached a stable state (GA) and ongoing maintenance ownership is established |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are no "following KEPs/Features"... so your work is already done? 😛
You probably had this in a different order initially and lost them during some reshuffling. I think this refers to the features under "Prioritization" now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, updated!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve For Steering. https://github.com/kubernetes/community/pull/8396/files#r2161652316 should better get resolved before merging. Also, needs a rebase... |
ddcdc26
to
90f9a50
Compare
Co-authored-by: Ryan Hallisey <rhallisey@nvidia.com>
90f9a50
to
149f04c
Compare
Updated and rebased. Thanks everyone! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: atiratree, pacoxu, pohly, soltysh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
With 4 steering members +1-ing (Paco, Patrick, Ben and myself) this is good to go as is based on the rules. /hold cancel |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few extra comments for the sake of history/documentation. I just hope someone will read them and have them in mind when we'll produce solutions.
- Consider improving the pod lifecycle of DaemonSets and static pods during a node maintenance. | ||
- Explore the cloud provider use cases and how they can hook into the node lifecycle. So that the | ||
users can use the same APIs or configurations across the board. | ||
- Migrate users of the eviction based kubectl-like drain (kubectl, cluster autoscaler, karpenter, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am a bit sad that kured was removed here, while it was in the initial comments on a previous issue.
I would like to adapt kured to this framework at least.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@evrardjp no worries! This list is not supposed to be exhaustive. We will properly explore the migration topic when the time comes.
FYI, kured is still present in https://github.com/kubernetes/community/blob/master/wg-node-lifecycle/charter.md#relevant-projects
- Explore a unified way of draining the nodes and managing node maintenance by introducing new APIs | ||
and extending the current ones. This includes exploring extension to or interactions with the Node | ||
object. | ||
- Analyze the node lifecycle, the Node API, and possible interactions. We want to explore augmenting |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we could have been more specific here. For example, analyse the possibility to set new conditions onto nodes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The WG charter does not replace a proper KEP; it only indicates the direction in which we would like to proceed. So we will even explore options that are not explicitly listed here.
We expect to provide reference implementations of the new APIs including but not limited to | ||
controllers (kube-controller-manager), API validation, integration with existing core components and | ||
extension points for the ecosystem. This should be accompanied by E2E / Conformance tests. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And cli...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CLI might be too broad. Nevertheless we talk about the kubectl above and will also further analyze it in our KEPs.
No description provided.