Skip to content

Remove PhantomJS stuff #3772

Open
Open
@jimmywarting

Description

@jimmywarting

I saw this and though, nobody is using phantomjs. it's a headless browser that no real user is using. it was based on webkit and the development have been discontinued. think you should remove this kind of things and instead use something like puppeteer or something.

// only really needed for phantom
function bind(func, thisArg) {
const curryArgs = Array.prototype.slice.call(arguments, 2);
return function() {
const args = curryArgs.concat(Array.prototype.slice.call(arguments, 0));
return func.apply(thisArg, args);
};
}

PhantomJS is depricated and should not be used anymore.

Activity

matthew-dean

matthew-dean commented on Mar 31, 2023

@matthew-dean
Member

Current tests use mocha-headless-chrome which uses Puppeteer, so @jimmywarting feel free to make a PR.

gadzbi123

gadzbi123 commented on May 17, 2023

@gadzbi123

This issue can be closed in reference to #3792

IAmRiteshKoushik

IAmRiteshKoushik commented on Jun 14, 2023

@IAmRiteshKoushik

Is this issue still up-for-grabs or has it been resolved ? If someone could help me out here a bit, then I would like to take up the issue and try resolving it.

TusharP05

TusharP05 commented on Jun 29, 2023

@TusharP05

is someone working on this? I will be happy to take up this issue and contribute.

linked a pull request that will close this issue on Jul 14, 2023
Groot-2001

Groot-2001 commented on Aug 18, 2023

@Groot-2001

Hey @matthew-dean , I would like to work on this issue!

IITI-tushar

IITI-tushar commented on Oct 31, 2024

@IITI-tushar

Hello! I wanted to kindly follow up on my PR PR #4283 regarding the removal of PhantomJS references in issue #3772. Thanks for your time and any feedback you can provide!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      Participants

      @matthew-dean@jimmywarting@gadzbi123@IAmRiteshKoushik@TusharP05

      Issue actions

        Remove PhantomJS stuff · Issue #3772 · less/less.js