Skip to content

feat: Support project context preview. #1551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 24, 2025
Merged

Conversation

Emt-lin
Copy link
Collaborator

@Emt-lin Emt-lin commented Jun 16, 2025

Overview

This PR introduces a major refactor of the project context manange system.

actual effect:

demo.mp4

Issue

#1540

Key changes

  • Add context based on category. eg: tag、folder、file、extension(Not currently supported)
  • add covert method for inclusions/exclusions PatternCategory to UI state object
    • createAndPopulateGroupList method: inclusions and exclusions convert to GroupList
    • convertGroupListToInclusions and convertDeletedItemsToExclusions method: groupList and DeletedItems convert to inclusions and exclusions

Test cases

Test file: tests/context-manage-modal.test.ts

Test createAndPopulateGroupList、convertGroupListToInclusions、convertDeletedItemsToExclusions method

@Emt-lin Emt-lin requested review from zeroliu and logancyang June 16, 2025 07:37
@Emt-lin Emt-lin force-pushed the project-context-preview branch from 20656b5 to 249ae74 Compare June 16, 2025 07:37
@Emt-lin Emt-lin marked this pull request as draft June 17, 2025 01:14
@Emt-lin Emt-lin marked this pull request as ready for review June 17, 2025 12:32
Copy link
Owner

@logancyang logancyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff! Can we remove the "extension" part? No need to pop "not supported", just remove it completely is fine.

@Emt-lin
Copy link
Collaborator Author

Emt-lin commented Jun 18, 2025

Can we remove the "extension" part? No need to pop "not supported", just remove it completely is fine.

If the user previously set up an extension, then removing the extension will hide this part of the context. @logancyang

@logancyang
Copy link
Owner

Can we remove the "extension" part? No need to pop "not supported", just remove it completely is fine.

If the user previously set up an extension, then removing the extension will hide this part of the context. @logancyang

It's ok, let's remove it. Having it doesn't make sense.

@logancyang
Copy link
Owner

bugbot run

cursor[bot]

This comment was marked as outdated.

@logancyang
Copy link
Owner

Let's prioritize merging this one by fixing those bugbot comments first @Emt-lin

@Emt-lin
Copy link
Collaborator Author

Emt-lin commented Jun 24, 2025

Let's prioritize merging this one by fixing those bugbot comments first @Emt-lin

fixed it. @logancyang

@Emt-lin Emt-lin requested a review from logancyang June 24, 2025 06:32
@logancyang
Copy link
Owner

bugbot run

Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ BugBot reviewed your changes and found no bugs!


Was this report helpful? Give feedback by reacting with 👍 or 👎

@Emt-lin
Copy link
Collaborator Author

Emt-lin commented Jun 24, 2025

How can i run this cursor bugbot @logancyang

@logancyang
Copy link
Owner

@Emt-lin only I can trigger it at the moment, the auto trigger isn't working. Let's see if it will allow proper auto triggers next.

@logancyang logancyang merged commit 4539338 into master Jun 24, 2025
3 checks passed
@logancyang logancyang deleted the project-context-preview branch June 24, 2025 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants