Skip to content

fix: panic on retrieving creation time in getFileStats #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

semihbkgr
Copy link
Contributor

It fixes two subtle issues when retrieving file created time (btime):

  • Use times.Stat instead of times.Get:
    times.Get doesn’t return btime on linux platforms, as noted:

Get(FileInfo) never returns btime.

  • Avoid panic when btime is unavailable:
    We need to check HasBirthTime() before calling BirthTime(), to prevent panic:
func (nobtime) BirthTime() time.Time { panic("birthtime not available") }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant