Feat(prompts): add DeletePrompts method to MCPServer

[God-Jay]

Description

add DeletePrompts method to MCPServer

Type of Change

• Bug fix (non-breaking change that fixes an issue)
• New feature (non-breaking change that adds functionality)
• MCP spec compatibility implementation
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Documentation update
• Code refactoring (no functional changes)
• Performance improvement
• Tests only (no functional changes)
• Other (please describe):

Checklist

• My code follows the code style of this project
• I have performed a self-review of my own code
• I have added tests that prove my fix is effective or that my feature works
• I have updated the documentation accordingly

MCP Spec Compliance

• This PR implements a feature defined in the MCP specification
• Link to relevant spec section: Link text
• Implementation follows the specification exactly

Additional Information

Summary by CodeRabbit

• New Features

  • Added the ability to remove one or more prompts by name. Users will receive notifications when the prompt list changes, such as after adding or deleting prompts.

• Bug Fixes

  • Improved notification accuracy when prompts are added or deleted, ensuring users are informed of prompt list updates.

• Tests

  • Introduced new tests to verify prompt addition, deletion, and notification behavior, including concurrent scenarios to ensure reliability.

[coderabbitai]

Walkthrough

A new method for deleting prompts by name was added to the MCPServer, along with corresponding notification logic for prompt list changes. Comments were updated for clarity. Race condition and unit tests were introduced to verify prompt deletion, notification behavior, and prompt list integrity during concurrent operations and standard usage.

Changes

File(s)	Change Summary
server/server.go	Added DeletePrompts method to MCPServer for removing prompts by name, updated comments for prompt/tool deletion.
server/server_race_test.go	Added a concurrent test operation to repeatedly add and delete prompts, testing for race conditions.
server/server_test.go	Introduced TestMCPServer_Prompts to verify prompt addition, deletion, notification, and prompt list correctness.

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 golangci-lint (1.64.8)

Error: you are using a configuration file for golangci-lint v2 with golangci-lint v1: please use golangci-lint v2
Failed executing command with error: you are using a configuration file for golangci-lint v2 with golangci-lint v1: please use golangci-lint v2

Note

⚡️ AI Code Reviews for VS Code, Cursor, Windsurf

CodeRabbit now has a plugin for VS Code, Cursor and Windsurf. This brings AI code reviews directly in the code editor. Each commit is reviewed immediately, finding bugs before the PR is raised. Seamless context handoff to your AI code agent ensures that you can easily incorporate review feedback.
Learn more here.

---

Note

⚡️ Faster reviews with caching

CodeRabbit now supports caching for code and dependencies, helping speed up reviews. This means quicker feedback, reduced wait times, and a smoother review experience overall. Cached data is encrypted and stored securely. This feature will be automatically enabled for all accounts on May 30th. To opt out, configure Review - Disable Cache at either the organization or repository level. If you prefer to disable all data retention across your organization, simply turn off the Data Retention setting under your Organization Settings.
Enjoy the performance boost—your workflow just got faster.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 17af676 and c0755b8.

📒 Files selected for processing (3)

• server/server.go (2 hunks)
• server/server_race_test.go (1 hunks)
• server/server_test.go (1 hunks)

🧰 Additional context used

🧬 Code Graph Analysis (1)

server/server_race_test.go (1)

mcp/prompts.go (3)

• Prompt (43-51)
• GetPromptRequest (20-28)
• GetPromptResult (32-37)

🔇 Additional comments (5)

server/server_race_test.go (1)

47-56: Good implementation of concurrent prompt deletion test

The new "delete-prompts" concurrent operation appropriately tests the race conditions for prompt deletion by creating a uniquely named prompt, adding it to the server, and immediately deleting it. This runs concurrently with other server operations to ensure thread safety of the new DeletePrompts functionality.

server/server.go (3)

406-406: Corrected comment reference

The comment now correctly refers to "prompts" instead of "resources" when describing the notification behavior.

---

413-431: Well-implemented DeletePrompts method

The DeletePrompts method follows the established pattern in the codebase, similar to DeleteTools:

1. Acquires the write lock on prompts mutex
2. Deletes specified prompts and their handlers if they exist
3. Tracks if any prompt was actually removed
4. Sends notifications only when prompts were actually deleted and capabilities allow

The implementation correctly handles synchronization and notification logic.

---

483-483: Corrected comment for DeleteTools

The comment now correctly indicates that the method can remove multiple tools, not just a single one.

server/server_test.go (1)

812-998: Thorough test suite for prompt deletion functionality

The new TestMCPServer_Prompts test suite comprehensively tests the DeletePrompts functionality with three test cases:

1. Deleting a prompt and verifying notifications are sent
2. Deleting one prompt while retaining others
3. Attempting to delete non-existent prompts and verifying no notifications are sent

Each test case properly validates both the notification behavior and the resulting prompt list state. The test structure follows the existing patterns in the codebase and provides good coverage of the new functionality.

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[pottekkat]

Thank you for the PR tidying up the comments as well.