-
Notifications
You must be signed in to change notification settings - Fork 642
fix(test/stdio): address io:read/write on closed pipe error #360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThe Changes
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 golangci-lint (1.64.8)Error: you are using a configuration file for golangci-lint v2 with golangci-lint v1: please use golangci-lint v2 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (2)
🔇 Additional comments (3)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Description
Fixes a potential
io: read/write on closed pipe
error that could occur in certain shutdown scenarios when testing StdioServer.Problem
When the context is canceled,
readNextLine
returns an empty string and nil error. This empty string is then passed intoprocessMessage
, which:writeResponse
.stdoutWriter
might already be closed, leading towrite on closed pipe
.Fix
stdoutWriter
at the sender side afterListen
exits:Previously, the test explicitly closed
stdoutWriter
from the test function, which could race with in-flight writes from the server and causewrite on closed pipe
errors. We now move thestdoutWriter.Close()
call to the end of the goroutine that runsstdioServer.Listen
, ensuring that the writer is only closed after all server writes have completed.processMessage
:If
readNextLine()
returns an empty string (due to context.Cancel()), we now skip processing inprocessMessage
. This ensures we don't try to decode or respond to invalid input, and allowscontext.Done()
to exit gracefully without triggering unintended writes.Proof




Type of Change
Checklist
MCP Spec Compliance
Additional Information
Summary by CodeRabbit
Bug Fixes
Tests