fix(client/transport/stream): check for nil pointer #404
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I noticed when you create a StreamableHTTP and pass empty options, there is the possibility for the application to crash due to a nil pointer on the empty option.
Fixes #<issue_number> (if applicable)
Type of Change
Checklist
My code follows the code style of this project
I have performed a self-review of my own code
I have added tests that prove my fix is effective or that my feature works
I have updated the documentation accordingly
This PR implements a feature defined in the MCP specification
Link to relevant spec section: Link text
Implementation follows the specification exactly
Additional Information
If you would like to replicate the issue, you can try this:
Summary by CodeRabbit