Skip to content

feat: add ResourceLink type and parsing support #407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 19, 2025

Conversation

chenmingyong0423
Copy link
Contributor

@chenmingyong0423 chenmingyong0423 commented Jun 18, 2025

Description

This PR adds support for parsing ResourceLink types according to the latest specification.

This PR adds the ResourceLink type implementation to align with the latest specification. The changes align with the specification defined at Model Context Protocol - Tools.

Type of Change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • MCP spec compatibility implementation
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Code refactoring (no functional changes)
  • Performance improvement
  • Tests only (no functional changes)
  • Other (please describe):

Checklist

  • My code follows the code style of this project
  • I have performed a self-review of my own code
  • I have added tests that prove my fix is effective or that my feature works
  • I have updated the documentation accordingly

MCP Spec Compliance

  • This PR implements a feature defined in the MCP specification
  • Link to relevant spec section: Link text
  • Implementation follows the specification exactly

Additional Information

  • Add ResourceLink type for tool result.
  • Add NewResourceLink function to create ResourceLink instances.
  • Add ResourceLink parsing support in ParseContent function.

Summary by CodeRabbit

  • New Features
    • Introduced support for a new "resource link" content type, allowing clients to access and display links to external resources with descriptive information.
  • Bug Fixes
    • Improved validation to ensure all required fields are present when handling resource links.

- Add ResourceLink type for tool result.
- Add NewResourceLink function to create ResourceLink instances.
- Add ResourceLink parsing support in ParseContent function.
Copy link
Contributor

coderabbitai bot commented Jun 18, 2025

Walkthrough

A new content type, ResourceLink, was introduced to represent resource links with associated metadata. The ResourceLink struct and its interface implementation were added, along with a constructor function. The content parsing logic was updated to recognize and validate the new "resource_link" type, ensuring all required fields are present.

Changes

File(s) Change Summary
mcp/types.go Added the ResourceLink struct with fields for resource metadata and implemented isContent() method.
mcp/utils.go Added NewResourceLink constructor and extended ParseContent to handle the "resource_link" type with validation.

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 golangci-lint (1.64.8)

Error: you are using a configuration file for golangci-lint v2 with golangci-lint v1: please use golangci-lint v2
Failed executing command with error: you are using a configuration file for golangci-lint v2 with golangci-lint v1: please use golangci-lint v2


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between dcd5c10 and cf8d285.

📒 Files selected for processing (2)
  • mcp/types.go (1 hunks)
  • mcp/utils.go (2 hunks)
🚧 Files skipped from review as they are similar to previous changes (2)
  • mcp/types.go
  • mcp/utils.go
✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🔭 Outside diff range comments (1)
mcp/utils.go (1)

71-98: Add missing AsResourceLink helper function for consistency.

All other content types have corresponding type assertion helpers, but ResourceLink is missing one. Add this function to maintain consistency:

 // AsEmbeddedResource attempts to cast the given interface to EmbeddedResource
 func AsEmbeddedResource(content any) (*EmbeddedResource, bool) {
 	return asType[EmbeddedResource](content)
 }

+// AsResourceLink attempts to cast the given interface to ResourceLink
+func AsResourceLink(content any) (*ResourceLink, bool) {
+	return asType[ResourceLink](content)
+}
+
 // AsTextResourceContents attempts to cast the given interface to TextResourceContents
 func AsTextResourceContents(content any) (*TextResourceContents, bool) {
 	return asType[TextResourceContents](content)
 }
🧹 Nitpick comments (1)
mcp/utils.go (1)

225-234: Consider reordering fields to match struct declaration.

The constructor works correctly but the field assignment order doesn't match the struct declaration order. Consider this minor adjustment for consistency:

 func NewResourceLink(uri, name, description, mimeType string) ResourceLink {
 	return ResourceLink{
 		Type:        "resource_link",
 		URI:         uri,
 		Name:        name,
+		Description: description,
 		MIMEType:    mimeType,
-		Description: description,
 	}
 }
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a077d27 and dcd5c10.

📒 Files selected for processing (2)
  • mcp/types.go (1 hunks)
  • mcp/utils.go (2 hunks)
🔇 Additional comments (2)
mcp/types.go (1)

868-882: LGTM! The ResourceLink implementation follows established patterns.

The struct definition correctly embeds Annotated, includes all necessary fields with proper JSON tags and documentation, and implements the Content interface consistently with other content types.

mcp/utils.go (1)

490-498: LGTM! The parsing logic is correctly implemented.

The resource_link case follows the established pattern for content parsing. Field validation and error handling are appropriate.

- Remove the requirement for description and mimeType when creating a ResourceLink, now only uri and name are mandatory.
- Update the comment for the mimeType field from "resource link" to "resource" for terminology consistency.
@dugenkui03 dugenkui03 merged commit 0fdb197 into mark3labs:main Jun 19, 2025
4 checks passed
@andig
Copy link

andig commented Jun 20, 2025

Could this be used to return external web links as resources as asked in #422?

omgitsads pushed a commit to omgitsads/mcp-go that referenced this pull request Jun 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants