Skip to content

fix(Pivot): Allow keyboard event to be received by onLinkClick event #34273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
May 28, 2025

Conversation

edwardUL99
Copy link
Contributor

Previous Behavior

We do not pass the keydown event to updateSelectedItem (possibly because this method previously only took mouse event). However, it is also triggered by keyboard enter, so clients should expect to be able to access the target property.

New Behavior

Pass the event from keydown to the updateSelectedItem method

Related Issue(s)

Copy link

github-actions bot commented Apr 16, 2025

📊 Bundle size report

Package & Exports Baseline (minified/GZIP) PR Change
react
Pivot
187.608 kB
56.481 kB
187.61 kB
56.481 kB
2 B
react
Fluent UI React (entire library)
1.019 MB
283.07 kB
1.019 MB
283.07 kB
2 B
Unchanged fixtures
Package & Exports Size (minified/GZIP)
react
ActivityItem
71.196 kB
23.345 kB
react
Announced
38.466 kB
13.274 kB
react
Autofill
15.42 kB
4.766 kB
react
Breadcrumb
200.693 kB
59.585 kB
react
Button
194.242 kB
55.873 kB
react
ButtonGrid
179.13 kB
53.878 kB
react
Calendar
121.126 kB
36.821 kB
react
Callout
84.233 kB
27.586 kB
react
Check
53.182 kB
17.832 kB
react
Checkbox
59.948 kB
19.872 kB
react
ChoiceGroup
65.458 kB
21.462 kB
react
ChoiceGroupOption
58.745 kB
19.351 kB
react
Coachmark
92.652 kB
29.303 kB
react
Color
7.789 kB
3.127 kB
react
ColorPicker
134.856 kB
42.11 kB
react
ComboBox
250.575 kB
71.498 kB
react
CommandBar
201.749 kB
59.376 kB
react
ContextualMenu
154.117 kB
47.553 kB
react
DatePicker
183.167 kB
55.873 kB
react
DateTimeUtilities
5.244 kB
1.849 kB
react
DetailsList
229.851 kB
65.756 kB
react
Dialog
210.048 kB
62.348 kB
react
Divider
19.582 kB
6.838 kB
react
DocumentCard
215.731 kB
63.643 kB
react
DragDrop
8.343 kB
2.724 kB
react
DraggableZone
34.28 kB
11.488 kB
react
Dropdown
232.997 kB
67.932 kB
react
ExtendedPicker
96.823 kB
27.867 kB
react
Fabric
41.722 kB
14.34 kB
react
Facepile
209.259 kB
62.362 kB
react
FloatingPicker
240.753 kB
68.209 kB
react
FocusTrapZone
16.978 kB
5.889 kB
react
FocusZone
55.1 kB
17.451 kB
react
Grid
179.13 kB
53.878 kB
react
GroupedList
135.012 kB
40.665 kB
react
GroupedListV2
122.629 kB
37.753 kB
react
HoverCard
96.718 kB
30.685 kB
react
Icon
51.863 kB
17.261 kB
react
Icons
66.339 kB
24.386 kB
react
Image
46.877 kB
15.692 kB
react
Keytip
81.241 kB
26.671 kB
react
KeytipData
14.032 kB
4.582 kB
react
KeytipLayer
103.029 kB
31.896 kB
react
Keytips
105.801 kB
32.898 kB
react
Label
38.318 kB
13.239 kB
react
Layer
48.077 kB
16.346 kB
react
Link
39.659 kB
13.651 kB
react
List
39.346 kB
12.454 kB
react
MarqueeSelection
74.484 kB
22.396 kB
react
MessageBar
189.276 kB
56.315 kB
react
Modal
93.678 kB
30.217 kB
react
Nav
186.713 kB
55.706 kB
react
OverflowSet
33.336 kB
11.279 kB
react
Overlay
40.879 kB
14.075 kB
react
Panel
200.215 kB
59.319 kB
react
Persona
114.513 kB
36.43 kB
react
PersonaCoin
114.513 kB
36.43 kB
react
PersonaPresence
58.052 kB
19.371 kB
react
Pickers
297.712 kB
82.962 kB
react
Popup
12.294 kB
4.195 kB
react
Positioning
22.764 kB
7.683 kB
react
PositioningContainer
73.415 kB
23.685 kB
react
ProgressIndicator
39.471 kB
13.526 kB
react
Rating
82.056 kB
26.085 kB
react
ResizeGroup
13.338 kB
4.377 kB
react
ResponsiveMode
8.13 kB
2.966 kB
react
ScrollablePane
55.535 kB
17.715 kB
react
SearchBox
187.512 kB
55.908 kB
react
SelectableOption
724 B
413 B
react
SelectedItemsList
231.238 kB
67.163 kB
react
Selection
42.418 kB
12.26 kB
react
Separator
35.359 kB
12.13 kB
react
Shimmer
49.237 kB
16.255 kB
react
ShimmeredDetailsList
240.633 kB
68.511 kB
react
Slider
57.615 kB
19.194 kB
react
SpinButton
191.185 kB
56.991 kB
react
Spinner
41.753 kB
14.466 kB
react
Stack
42.03 kB
14.386 kB
react
Sticky
32.577 kB
10.488 kB
react
Styling
46.033 kB
15.135 kB
react
SwatchColorPicker
189.525 kB
57.405 kB
react
TeachingBubble
204.527 kB
60.294 kB
react
Text
36.886 kB
12.806 kB
react
TextField
80.768 kB
25.3 kB
react
Theme
43.486 kB
14.168 kB
react
ThemeGenerator
12.384 kB
4.116 kB
react
TimePicker
240.403 kB
69.296 kB
react
Toggle
46.189 kB
15.954 kB
react
Tooltip
87.013 kB
28.144 kB
react
Utilities
82.932 kB
25.149 kB
react
Viewport
23.872 kB
7.642 kB
react
WeeklyDayPicker
101.318 kB
31.637 kB
react
WindowProvider
1.059 kB
541 B
🤖 This report was generated against a97599101b9208c75b687f200c57740313a2c2e3

Copy link

Pull request demo site: URL

@edwardUL99 edwardUL99 marked this pull request as ready for review April 17, 2025 07:32
@edwardUL99
Copy link
Contributor Author

Integration tests failing as certain pre-checks are skipped:
image

@TristanWatanabe TristanWatanabe changed the title Allow keyboard event to be received by onLinkClick event fix(Pivot): Allow keyboard event to be received by onLinkClick event Apr 17, 2025
@TristanWatanabe
Copy link
Member

Integration tests failing as certain pre-checks are skipped: image

You don't have to worry about these checks as they are expected to fail right now

Copy link
Member

@TristanWatanabe TristanWatanabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@edwardUL99 This LGTM - thanks for the contribution!

@TristanWatanabe TristanWatanabe merged commit 4d7465d into microsoft:master May 28, 2025
12 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Pressing Enter on PivotItem does not pass the event object to onLinkClick,
3 participants