-
Notifications
You must be signed in to change notification settings - Fork 2.8k
fix(Pivot): Allow keyboard event to be received by onLinkClick event #34273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
TristanWatanabe
merged 10 commits into
microsoft:master
from
edwardUL99:fix_pivot_click
May 28, 2025
Merged
fix(Pivot): Allow keyboard event to be received by onLinkClick event #34273
TristanWatanabe
merged 10 commits into
microsoft:master
from
edwardUL99:fix_pivot_click
May 28, 2025
+14
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
📊 Bundle size report
Unchanged fixtures
|
Pull request demo site: URL |
change/@fluentui-react-6c19b63b-2401-42ce-ae11-4e6c7c0f95e3.json
Outdated
Show resolved
Hide resolved
change/@fluentui-react-6c19b63b-2401-42ce-ae11-4e6c7c0f95e3.json
Outdated
Show resolved
Hide resolved
TristanWatanabe
approved these changes
May 28, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@edwardUL99 This LGTM - thanks for the contribution!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous Behavior
We do not pass the keydown event to
updateSelectedItem
(possibly because this method previously only took mouse event). However, it is also triggered by keyboard enter, so clients should expect to be able to access the target property.New Behavior
Pass the event from keydown to the updateSelectedItem method
Related Issue(s)