Skip to content

Semantic-tokens: React-button #34276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

Mitch-At-Work
Copy link
Contributor

@Mitch-At-Work Mitch-At-Work commented Apr 16, 2025

  • Base Button
  • Compound Button
  • MenuButton
  • SplitButton
  • ToggleButton

Token gaps (vs semantic):

  • Need alternate tokens for Compound spacing as it's a larger variant than default small/medium/large
  • 'Selected' button states are not present in semantic-tokens, these original token variants will remain (for now).
  • V9 Buttons have some hardcoded vertical padding tokens, avoid for now, could be tokenized via more button optional tokens if requested.

Copy link

Pull request demo site: URL

@Mitch-At-Work Mitch-At-Work force-pushed the user/mifraser/react-button-semantic-tokens branch from e30d81c to 82f96b4 Compare April 22, 2025 18:29
@Mitch-At-Work Mitch-At-Work marked this pull request as ready for review April 25, 2025 22:46
@Mitch-At-Work Mitch-At-Work requested review from a team and khmakoto as code owners April 25, 2025 22:46
@Mitch-At-Work Mitch-At-Work force-pushed the user/mifraser/react-button-semantic-tokens branch from ac4e008 to 0f8d8c5 Compare April 28, 2025 17:32
@tudorpopams tudorpopams requested a review from marcosmoura April 29, 2025 12:03
@Mitch-At-Work Mitch-At-Work force-pushed the user/mifraser/react-button-semantic-tokens branch 2 times, most recently from 2eda569 to e622873 Compare May 15, 2025 19:33
@Mitch-At-Work Mitch-At-Work force-pushed the user/mifraser/react-button-semantic-tokens branch from e622873 to fc4f8cd Compare May 15, 2025 20:42
@Mitch-At-Work Mitch-At-Work merged commit b79b1c2 into microsoft:extended-tokens May 20, 2025
10 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants