Skip to content

Handling missing and duplicate values in Area chart #34340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
May 8, 2025
Merged

Handling missing and duplicate values in Area chart #34340

merged 9 commits into from
May 8, 2025
+261 −41

Conversation

srmukher
Copy link
Contributor

@srmukher srmukher commented Apr 28, 2025 •
edited
Loading

@srmukher srmukher requested a review from a team as a code owner April 28, 2025 19:22
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 28, 2025 •
edited
Loading

📊 Bundle size report

✅ No changes found

@github-actions GitHub Actions
Copy link

Pull request demo site: URL

AtishayMsft
AtishayMsft reviewed Apr 29, 2025
View reviewed changes
@AtishayMsft
Copy link
Contributor

Could you run playwright tests on test app to ensure nothing is regressing.

@srmukher
Copy link
Contributor Author

srmukher commented May 6, 2025 •
edited
Loading

Could you run playwright tests on test app to ensure nothing is regressing.

@AtishayMsft playwright report gave same results for both my changes and the latest version 5.23.80
image

@AtishayMsft
Copy link
Contributor

Could you run playwright tests on test app to ensure nothing is regressing.

@AtishayMsft playwright report gave same results for both my changes and the latest version 5.23.80 image

I updated the baseline screenshots to latest version earlier in the day. Could you run again.

@srmukher
Copy link
Contributor Author

srmukher commented May 7, 2025

Could you run playwright tests on test app to ensure nothing is regressing.

@AtishayMsft playwright report gave same results for both my changes and the latest version 5.23.80 image

I updated the baseline screenshots to latest version earlier in the day. Could you run again.

Report from my change:
image

Report from latest version in master:
image

@AtishayMsft
Copy link
Contributor

Could you run playwright tests on test app to ensure nothing is regressing.

@AtishayMsft playwright report gave same results for both my changes and the latest version 5.23.80 image

I updated the baseline screenshots to latest version earlier in the day. Could you run again.

Report from my change: image

Report from latest version in master: image

The 5 additional failures are the cases that are fixed with this change?

@srmukher
Copy link
Contributor Author

srmukher commented May 7, 2025

Could you run playwright tests on test app to ensure nothing is regressing.

@AtishayMsft playwright report gave same results for both my changes and the latest version 5.23.80 image

I updated the baseline screenshots to latest version earlier in the day. Could you run again.

Report from my change: image
Report from latest version in master: image

The 5 additional failures are the cases that are fixed with this change?

No, these are unrelated to my changes as discussed offline related to HBC. Manually checked all area chart examples and found no regressions.

@srmukher srmukher merged commit dcda99a into microsoft:master May 8, 2025
12 of 15 checks passed
@srmukher srmukher deleted the users/srmukher/area_dup branch May 8, 2025 05:37
marcosmoura added a commit to marcosmoura/fluentui that referenced this pull request May 9, 2025
@marcosmoura
Merge remote-tracking branch 'origin/master' into feat/react-text/cre…
37c1b6a 
…ate-TextProvider

* origin/master: (29 commits)
  release: applying package updates - react v8
  release: applying package updates - web-components
  fix(react-charting): High Contrast fix (microsoft#34393)
  release: applying package updates - react v8
  Handling missing and duplicate values in Area chart (microsoft#34340)
  release: applying package updates - web-components
  [fix] focus-visible state for primary selected focus state for toggle button and primary hover button (microsoft#34400)
  [fix] inverted spinner story to not theme background (microsoft#34396)
  React-Carousel: Ensure compliant brand variant contrast (microsoft#34397)
  refactor(motion): simplify Fade & Scale variant creation with `createPresenceComponentVariant` (microsoft#34042)
  feat: deprecate `safeMount` and remove its abstractions in react project tests (microsoft#34390)
  [fix]: storybook style was preventing dialog text from theming (microsoft#34394)
  chore: remove enzyme setup from projects that dont use it anymore (microsoft#34386)
  Fluent UI v9 test cases - HorizontalBarChartWithAxis, Area chart and GroupedVerticalbarChart (microsoft#34378)
  test: resolve v8 act() issues with react 18  (microsoft#34376)
  ci: remove unused milestone automation (microsoft#34392)
  chore(deps-dev): bump memfs from 3.2.2 to 3.5.3 (microsoft#34385)
  chore(deps): fix critical,high and moderate severity security vulnerabilities  (microsoft#34368)
  ci: disable dependabot major deps updates (microsoft#34367)
  release: applying package updates - react v8
  ...
dmytrokirpa pushed a commit to dmytrokirpa/fluentui that referenced this pull request May 27, 2025
@srmukher @dmytrokirpa
Handling missing and duplicate values in Area chart (microsoft#34340)
52cb0db
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot]

@AtishayMsft AtishayMsft

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@srmukher @AtishayMsft