Skip to content

Commit 97c2524

Browse files
authored
.Net: [MEVD] Removed Experimental flag from GetService method (#11808)
### Motivation and Context <!-- Thank you for your contribution to the semantic-kernel repo! Please help reviewers and future users, providing the following information: 1. Why is this change required? 2. What problem does it solve? 3. What scenario does it contribute to? 4. If it fixes an open issue, please link to the issue here. --> Removed Experimental flag from GetService method as discussed during design review meeting. ### Description <!-- Describe your changes, the overall approach, the underlying design. These notes will help understanding how your code works. Thanks! --> ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [x] The code builds clean without any errors or warnings - [x] The PR follows the [SK Contribution Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [x] All unit tests pass, and I have added new tests where possible - [x] I didn't break anyone 😄
1 parent 1f9685f commit 97c2524

9 files changed

+0
-20
lines changed

dotnet/src/Connectors/VectorData.Abstractions/VectorSearch/IKeywordHybridSearch.cs

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@
22

33
using System;
44
using System.Collections.Generic;
5-
using System.Diagnostics.CodeAnalysis;
65
using System.Threading;
76

87
namespace Microsoft.Extensions.VectorData;
@@ -40,6 +39,5 @@ IAsyncEnumerable<VectorSearchResult<TRecord>> HybridSearchAsync<TVector>(
4039
/// including itself or any services it might be wrapping. For example, to access the <see cref="VectorStoreRecordCollectionMetadata"/> for the instance,
4140
/// <see cref="GetService"/> may be used to request it.
4241
/// </remarks>
43-
[Experimental("MEVD9000")]
4442
object? GetService(Type serviceType, object? serviceKey = null);
4543
}

dotnet/src/Connectors/VectorData.Abstractions/VectorSearch/IVectorSearch.cs

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@
22

33
using System;
44
using System.Collections.Generic;
5-
using System.Diagnostics.CodeAnalysis;
65
using System.Threading;
76
using Microsoft.Extensions.AI;
87

@@ -66,6 +65,5 @@ IAsyncEnumerable<VectorSearchResult<TRecord>> SearchEmbeddingAsync<TVector>(
6665
/// including itself or any services it might be wrapping. For example, to access the <see cref="VectorStoreRecordCollectionMetadata"/> for the instance,
6766
/// <see cref="GetService"/> may be used to request it.
6867
/// </remarks>
69-
[Experimental("MEVD9000")]
7068
object? GetService(Type serviceType, object? serviceKey = null);
7169
}

dotnet/src/Connectors/VectorData.Abstractions/VectorSearch/IVectorizableTextSearch.cs

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@
22

33
using System;
44
using System.Collections.Generic;
5-
using System.Diagnostics.CodeAnalysis;
65
using System.Threading;
76

87
namespace Microsoft.Extensions.VectorData;
@@ -38,6 +37,5 @@ IAsyncEnumerable<VectorSearchResult<TRecord>> VectorizableTextSearchAsync(
3837
/// including itself or any services it might be wrapping. For example, to access the <see cref="VectorStoreRecordCollectionMetadata"/> for the instance,
3938
/// <see cref="GetService"/> may be used to request it.
4039
/// </remarks>
41-
[Experimental("MEVD9000")]
4240
object? GetService(Type serviceType, object? serviceKey = null);
4341
}

dotnet/src/Connectors/VectorData.Abstractions/VectorSearch/KeywordHybridSearchExtensions.cs

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,10 @@
11
// Copyright (c) Microsoft. All rights reserved.
22

33
using System;
4-
using System.Diagnostics.CodeAnalysis;
54

65
namespace Microsoft.Extensions.VectorData;
76

87
/// <summary>Provides a collection of static methods for extending <see cref="IKeywordHybridSearch{TRecord}"/> instances.</summary>
9-
[Experimental("MEVD9000")]
108
public static class KeywordHybridSearchExtensions
119
{
1210
/// <summary>

dotnet/src/Connectors/VectorData.Abstractions/VectorSearch/VectorSearchExtensions.cs

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,10 @@
11
// Copyright (c) Microsoft. All rights reserved.
22

33
using System;
4-
using System.Diagnostics.CodeAnalysis;
54

65
namespace Microsoft.Extensions.VectorData;
76

87
/// <summary>Provides a collection of static methods for extending <see cref="IVectorizedSearch{TRecord}"/> instances.</summary>
9-
[Experimental("MEVD9000")]
108
public static class VectorSearchExtensions
119
{
1210
/// <summary>

dotnet/src/Connectors/VectorData.Abstractions/VectorStorage/IVectorStore.cs

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@
22

33
using System;
44
using System.Collections.Generic;
5-
using System.Diagnostics.CodeAnalysis;
65
using System.Threading;
76
using System.Threading.Tasks;
87

@@ -69,6 +68,5 @@ IVectorStoreRecordCollection<TKey, TRecord> GetCollection<TKey, TRecord>(string
6968
/// including itself or any services it might be wrapping. For example, to access the <see cref="VectorStoreMetadata"/> for the instance,
7069
/// <see cref="GetService"/> may be used to request it.
7170
/// </remarks>
72-
[Experimental("MEVD9000")]
7371
object? GetService(Type serviceType, object? serviceKey = null);
7472
}

dotnet/src/Connectors/VectorData.Abstractions/VectorStorage/VectorStoreExtensions.cs

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,10 @@
11
// Copyright (c) Microsoft. All rights reserved.
22

33
using System;
4-
using System.Diagnostics.CodeAnalysis;
54

65
namespace Microsoft.Extensions.VectorData;
76

87
/// <summary>Provides a collection of static methods for extending <see cref="IVectorStore"/> instances.</summary>
9-
[Experimental("MEVD9000")]
108
public static class VectorStoreExtensions
119
{
1210
/// <summary>

dotnet/src/Connectors/VectorData.Abstractions/VectorStorage/VectorStoreMetadata.cs

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,8 @@
11
// Copyright (c) Microsoft. All rights reserved.
22

3-
using System.Diagnostics.CodeAnalysis;
4-
53
namespace Microsoft.Extensions.VectorData;
64

75
/// <summary>Provides metadata about an <see cref="IVectorStore"/>.</summary>
8-
[Experimental("MEVD9000")]
96
public class VectorStoreMetadata
107
{
118
/// <summary>The name of the vector store system.</summary>

dotnet/src/Connectors/VectorData.Abstractions/VectorStorage/VectorStoreRecordCollectionMetadata.cs

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,8 @@
11
// Copyright (c) Microsoft. All rights reserved.
22

3-
using System.Diagnostics.CodeAnalysis;
4-
53
namespace Microsoft.Extensions.VectorData;
64

75
/// <summary>Provides metadata about an <see cref="IVectorStoreRecordCollection{TKey, TRecord}"/>.</summary>
8-
[Experimental("MEVD9000")]
96
public class VectorStoreRecordCollectionMetadata
107
{
118
/// <summary>The name of the vector store system.</summary>

0 commit comments

Comments
 (0)