Skip to content

.Net: [MEVD] Change the GetAsync sorting API to allowing specifying sorting in-line #11855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
roji opened this issue May 2, 2025 · 1 comment
Assignees
Labels
Build Features planned for next Build conference msft.ext.vectordata Related to Microsoft.Extensions.VectorData .NET Issue or Pull requests regarding .NET code

Comments

@roji
Copy link
Member

roji commented May 2, 2025

The way the current GetAsync sorting is designed,

GetFilteredRecordOptions<FilterRecord> options = new();

options.OrderBy
    .Ascending(r => r.Int)
    .Descending(r => r.String);

await foreach (var r in fixture.Collection.GetAsync(r => r.Int == 8, top: 3, options))
{
    // ....
}

As discussed in API review, we should make changes to allow it to be specified in line (both for usability and for other languages, F#);

await foreach (var r in fixture.Collection.GetAsync(
    r => r.Int == 8,
    top: 3,
    new()
    {
        OrderBy = r => r.Ascending(r => r.Int).Descending(r => r.String)
    });
@roji roji added .NET Issue or Pull requests regarding .NET code Build Features planned for next Build conference msft.ext.vectordata Related to Microsoft.Extensions.VectorData labels May 2, 2025
@roji roji moved this to Backlog: Planned in Semantic Kernel May 2, 2025
@github-actions github-actions bot changed the title [MEVD] Change the GetAsync sorting API to allowing specifying sorting in-line .Net: [MEVD] Change the GetAsync sorting API to allowing specifying sorting in-line May 2, 2025
@adamsitnik
Copy link
Member

Fixed with #11930

@adamsitnik adamsitnik moved this from Backlog: Planned to Sprint: Done in Semantic Kernel May 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Build Features planned for next Build conference msft.ext.vectordata Related to Microsoft.Extensions.VectorData .NET Issue or Pull requests regarding .NET code
Projects
Archived in project
Development

No branches or pull requests

4 participants