.Net: Support BinaryContent in OpenAI Connector #11644
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markwallace-microsoft
added
.NET
|
Hi @nkeenan38 Thanks for the contribution, Please add one Integration Test and a Sample ensuring it works as expected and the file content is passed down to the API. Concept Samples - Similar to thisIntegration Tests - Similar to this: |
|
@microsoft-github-policy-service agree |
nkeenan38
force-pushed
the
openai-connector-binary-content
branch
from
153a362 to
f0a5119
Compare
RogerBarreto
approved these changes
Apr 22, 2025
dotnet/src/Connectors/Connectors.OpenAI/Core/ClientCore.ChatCompletion.cs
Show resolved
Hide resolved
nkeenan38
force-pushed
the
openai-connector-binary-content
branch
from
fb69f2b to
7895d54
Compare
nkeenan38
force-pushed
the
openai-connector-binary-content
branch
from
7895d54 to
5cad4b3
Compare
RogerBarreto
temporarily deployed
to
integration
GitHub Actions
Inactive
RogerBarreto
approved these changes
Apr 24, 2025
There was a problem hiding this comment.
@nkeenan38 Thanks for addressing all feedback and putting forward this PR.
All looks good to me.
SergeyMenshykh
approved these changes
Apr 24, 2025
markwallace-microsoft
approved these changes
Apr 24, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
…nto openai-connector-binary-content
…nkeenan38/semantic-kernel into openai-connector-binary-content
RogerBarreto
temporarily deployed
to
integration
GitHub Actions
Inactive
markwallace-microsoft
approved these changes
Apr 29, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-project-automation
bot
moved this from Sprint: In Review
to Sprint: Done
in Semantic Kernel
glorious-beard
pushed a commit
to glorious-beard/semantic-kernel
that referenced
this pull request
May 6, 2025
The OpenAI Connector only supports `TextContent`, `ImageContent`, and `AudioContent` KernelContent types. However, the Chat Completion API supports uploading other file types encoded as a base64 string. This change leverages that behavior to add support for `BinaryContent`. This change adds support for `BinaryContent` KernelContent types by using `ChatMessageContentPart.CreateFilePart` to create the corresponding `ChatMessageContentPart`. - [x] The code builds clean without any errors or warnings - [x] The PR follows the [SK Contribution Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [x] All unit tests pass, and I have added new tests where possible - [x] I didn't break anyone 😄 --------- Co-authored-by: Roger Barreto <19890735+RogerBarreto@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
The OpenAI Connector only supports
TextContent,ImageContent, andAudioContentKernelContent types. However, the Chat Completion API supports uploading other file types encoded as a base64 string. This change leverages that behavior to add support forBinaryContent.Description
This change adds support for
BinaryContentKernelContent types by usingChatMessageContentPart.CreateFilePartto create the correspondingChatMessageContentPart.Contribution Checklist