-
Notifications
You must be signed in to change notification settings - Fork 3.9k
Python: Support callers passing in max supersteps for processes #11798
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
eavanvalkenburg
merged 1 commit into
microsoft:main
from
moonbox3:py-processes-max-super-step
Apr 30, 2025
Merged
Python: Support callers passing in max supersteps for processes #11798
eavanvalkenburg
merged 1 commit into
microsoft:main
from
moonbox3:py-processes-max-super-step
Apr 30, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR enables callers to specify a custom value for max_supersteps, allowing more flexible control over process execution. Key changes include:
- Adding tests to validate the custom max_supersteps configuration.
- Updating both local and Dapr runtime process contexts and processes to accept and propagate the max_supersteps parameter.
- Enhancing documentation to describe how to configure max_supersteps.
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated no comments.
Show a summary per file
File | Description |
---|---|
python/tests/unit/processes/local_runtime/test_local_process.py | Added test to validate max_supersteps initialization. |
python/tests/unit/processes/dapr_runtime/test_dapr_kernel_process_context.py | Updated expected payload to include max_supersteps. |
python/tests/unit/processes/dapr_runtime/test_dapr_kernel_process.py | Modified tests to pass and assert max_supersteps. |
python/semantic_kernel/processes/local_runtime/local_process.py | Updated init and start to accept and use max_supersteps. |
python/semantic_kernel/processes/local_runtime/local_kernel_process_context.py | Propagated max_supersteps to LocalProcess. |
python/semantic_kernel/processes/local_runtime/local_kernel_process.py | Extended start function to accept max_supersteps and pass it to the context. |
python/semantic_kernel/processes/dapr_runtime/dapr_kernel_process_context.py | Modified init and start_with_event to support max_supersteps. |
python/semantic_kernel/processes/dapr_runtime/dapr_kernel_process.py | Updated start function to relay max_supersteps. |
python/semantic_kernel/processes/dapr_runtime/actors/process_actor.py | Adjusted actor initialization and internal execution for max_supersteps. |
python/samples/getting_started_with_processes/README.md | Documented configuration and usage of max_supersteps. |
Python Unit Test Overview
|
TaoChenOSU
approved these changes
Apr 29, 2025
eavanvalkenburg
approved these changes
Apr 30, 2025
3697675
to
21ebb64
Compare
glorious-beard
pushed a commit
to glorious-beard/semantic-kernel
that referenced
this pull request
May 6, 2025
…osoft#11798) ### Motivation and Context Today in Python processes the `max_supersteps` config is hidden from the caller. The internal execute method defaults the value to 100, and this doesn't allow for developers to leverage custom values depending on their use cases. <!-- Thank you for your contribution to the semantic-kernel repo! Please help reviewers and future users, providing the following information: 1. Why is this change required? 2. What problem does it solve? 3. What scenario does it contribute to? 4. If it fixes an open issue, please link to the issue here. --> ### Description Provide a way for callers to pass in `max_supersteps` via the process runtime `start` method. - Update README - Update unit tests accordingly. <!-- Describe your changes, the overall approach, the underlying design. These notes will help understanding how your code works. Thanks! --> ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [X] The code builds clean without any errors or warnings - [X] The PR follows the [SK Contribution Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [X] All unit tests pass, and I have added new tests where possible - [X] I didn't break anyone 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Today in Python processes the
max_supersteps
config is hidden from the caller. The internal execute method defaults the value to 100, and this doesn't allow for developers to leverage custom values depending on their use cases.Description
Provide a way for callers to pass in
max_supersteps
via the process runtimestart
method.Contribution Checklist