Skip to content

.Net: [MEVD] Removed Experimental flag from GetService method #11808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

dmytrostruk
Copy link
Member

Motivation and Context

Removed Experimental flag from GetService method as discussed during design review meeting.

Description

Contribution Checklist

@dmytrostruk dmytrostruk self-assigned this Apr 29, 2025
@dmytrostruk dmytrostruk requested a review from a team as a code owner April 29, 2025 18:03
@markwallace-microsoft markwallace-microsoft added .NET Issue or Pull requests regarding .NET code kernel Issues or pull requests impacting the core kernel labels Apr 29, 2025
@dmytrostruk dmytrostruk added this pull request to the merge queue May 1, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 1, 2025
@dmytrostruk dmytrostruk added this pull request to the merge queue May 1, 2025
Merged via the queue into microsoft:main with commit 97c2524 May 1, 2025
20 checks passed
@dmytrostruk dmytrostruk deleted the mevd-remove-experimental-flags branch May 1, 2025 14:42
glorious-beard pushed a commit to glorious-beard/semantic-kernel that referenced this pull request May 6, 2025
…oft#11808)

### Motivation and Context

<!-- Thank you for your contribution to the semantic-kernel repo!
Please help reviewers and future users, providing the following
information:
  1. Why is this change required?
  2. What problem does it solve?
  3. What scenario does it contribute to?
  4. If it fixes an open issue, please link to the issue here.
-->

Removed Experimental flag from GetService method as discussed during
design review meeting.

### Description

<!-- Describe your changes, the overall approach, the underlying design.
These notes will help understanding how your code works. Thanks! -->

### Contribution Checklist

<!-- Before submitting this PR, please make sure: -->

- [x] The code builds clean without any errors or warnings
- [x] The PR follows the [SK Contribution
Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md)
and the [pre-submission formatting
script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts)
raises no violations
- [x] All unit tests pass, and I have added new tests where possible
- [x] I didn't break anyone 😄
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kernel Issues or pull requests impacting the core kernel .NET Issue or Pull requests regarding .NET code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants