.Net: Remove IMemoryStore and references to SK from MEVD #11811
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markwallace-microsoft
added
.NET
github-actions
bot
changed the title
roji
commented
Apr 29, 2025
| @@ -1,5 +1,7 @@ | |||
| // Copyright (c) Microsoft. All rights reserved. | |||
|
|
|||
| #if DISABLED | |||
There was a problem hiding this comment.
@westey-m I've converted some other samples which show how to connect via MEVD to an IMemoryStore-created collection, but this one is slightly different since it shows an actual data migration... We should decide what we want to do with it (but can probably do it later?).
markwallace-microsoft
approved these changes
Apr 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the IMemoryStore implementations - and all supporting code - from all MEVD connectors. It also removes the reference to Microsoft.SemanticKernel.Core from the MEVD connectors.
Note that this doesn't remove IMemoryStore itself, and non-MEVD connectors (e.g. Chroma, Milvus) are untouched.
Closes #10855