.Net: MEVD Feature Branch 3 #11831
Merged
.Net: MEVD Feature Branch 3 #11831
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markwallace-microsoft
added
.NET
### Motivation and Context #11512 #11552 ### Description <!-- Describe your changes, the overall approach, the underlying design. These notes will help understanding how your code works. Thanks! --> ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [ ] The code builds clean without any errors or warnings - [ ] The PR follows the [SK Contribution Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [ ] All unit tests pass, and I have added new tests where possible - [ ] I didn't break anyone 😄
Following #11832, this shortens the names of provider implementation types as discussed in API review (e.g. AzureCosmosDBMongoDBVectorStoreRecordCollection -> CosmosMongoCollection) * For Cosmos, I've left CosmosMongo vs. CosmosNoSql (note lower-case Sql rather than the previous SQL) to disambiguate, as discussed in API review. * We could also shorten PostgresVectorStore to PostgresStore (similar to how we have PostgresCollection now). For now I'm leaving PostgresVectorStore - we can discuss. * No namespaces/nuget package names are touched - I'll do this in a later PR. Closes #11230
* Constrain TRecord to class
* Rename search interfaces
* IVectorSearch -> IVectorSearchable
* IKeywordHybridSearch -> IKeywordHybridSearchable
* Rename option bag types
* GetRecordOptions -> RecordRetrievalOptions
* GetFilteredRecordOptions -> FilteredRecordRetrievalOptions
* VectorSearchOptions -> RecordSearchOptions
* Make collection option types non-generic
* Make record definition property types mutable
* Rename ConnectorSupport -> ProviderServices
* Merge VectorStoreOperationException into VectorStoreException
Closes #11880
Closes #10879
we no longer provide a public PineconeClient type, so there is no need to use fully qualified name when using the official Pincone types
From API review.
roji
approved these changes
May 19, 2025
markwallace-microsoft
approved these changes
May 19, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
roji
approved these changes
May 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Feature branch PR containing all MEVD contributions
Description
Contribution Checklist