Skip to content

.Net: Use SendWithSuccessCheck extension methods #11859

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

SergeyMenshykh
Copy link
Member

Motivation, Context and Description

This PR refactors the SessionsPythonPlugin to use the SendWithSuccessCheckAsync extension methods to align the handling of HTTP requests with the other SK components. Additionally, it fixes minor logging-related issues and moves a private method down the plugin file for better readability.

Contributes to: #10070

@SergeyMenshykh SergeyMenshykh added .NET Issue or Pull requests regarding .NET code core plugin Anything related to core plugins labels May 2, 2025
@SergeyMenshykh SergeyMenshykh self-assigned this May 2, 2025
@SergeyMenshykh SergeyMenshykh requested a review from a team as a code owner May 2, 2025 12:33
@SergeyMenshykh SergeyMenshykh moved this to Sprint: In Progress in Semantic Kernel May 2, 2025
@SergeyMenshykh SergeyMenshykh moved this from Sprint: In Progress to Sprint: In Review in Semantic Kernel May 2, 2025
@SergeyMenshykh SergeyMenshykh enabled auto-merge May 2, 2025 12:38
@SergeyMenshykh SergeyMenshykh added this pull request to the merge queue May 2, 2025
Merged via the queue into microsoft:main with commit 46e5744 May 2, 2025
24 checks passed
@SergeyMenshykh SergeyMenshykh deleted the use-send-with-success-check-methods-for-python-interpreter branch May 2, 2025 17:47
@github-project-automation github-project-automation bot moved this from Sprint: In Review to Sprint: Done in Semantic Kernel May 2, 2025
glorious-beard pushed a commit to glorious-beard/semantic-kernel that referenced this pull request May 6, 2025
### Motivation, Context and Description

This PR refactors the `SessionsPythonPlugin` to use the
`SendWithSuccessCheckAsync` extension methods to align the handling of
HTTP requests with the other SK components. Additionally, it fixes minor
logging-related issues and moves a private method down the plugin file
for better readability.

Contributes to:
microsoft#10070
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core plugin Anything related to core plugins .NET Issue or Pull requests regarding .NET code
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants