.Net: Convert IVectorStore and IVectorStoreCollection from interfaces to base classes #11860
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markwallace-microsoft
added
.NET
github-actions
bot
changed the title
westey-m
reviewed
May 2, 2025
| @@ -18,7 +18,7 @@ namespace Microsoft.Extensions.VectorData; | |||
| /// </remarks> | |||
| #pragma warning disable CA1711 // Identifiers should not have incorrect suffix (Collection) | |||
| #pragma warning disable CS0618 // IVectorizedSearch is obsolete | |||
| public interface IVectorStoreCollection<TKey, TRecord> : IVectorSearch<TRecord>, IVectorizedSearch<TRecord> | |||
| public abstract class VectorStoreCollection<TKey, TRecord> : IVectorSearch<TRecord>, IVectorizedSearch<TRecord> | |||
There was a problem hiding this comment.
Remember to update the xml docs for this type too. I see some references to interface above.
westey-m
reviewed
May 2, 2025
| where TVector : notnull; | ||
|
|
||
| /// <inheritdoc /> | ||
| [Obsolete("Use either SearchEmbeddingAsync to search directly on embeddings, or SearchAsync to handle embedding generation internally as part of the call.")] |
There was a problem hiding this comment.
Maybe not for this PR, but I suppose we can remove this now anyway, since we obsoleted it in the last release.
There was a problem hiding this comment.
Yeah, absolutely. This - and some other obsoleted APIs - indeed need to be removed.
westey-m
approved these changes
May 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #11775