Back Button in Settings

[Techypanda]

Summary of the Pull Request

This PR makes it so that if you are in a 'nested' context e.g. Advanced Settings, a back button will appear, this is consistent with Windows UI (see Settings and go to a nested page and see in the top left a back button will appear).

References and Relevant Issues

#18658

Detailed Description of the Pull Request / Additional comments

This is done by enabling the native back button in the navigation list IFF the breadcrumbs length is >1 (i.e nested context).

Validation Steps Performed

• Built Locally & Tested Locally on nested pages

PR Checklist

• Closes Back Button in Settings #18658
• Tests added/passed (Need guidance as to if and where I need to add tests for this)
• Documentation updated (N/A?)
  • If checked, please file a pull request on our docs repo and link it here: #xxx
• Schema updated (if necessary) (N/A?)

[carlos-zamora]

Thanks for doing this! Downloaded the branch and played around with it for a while.

I noticed that the back button only appears if we're in a subpage. I'd prefer that we have it always be visible, but we change the enabled/disabled state appropriately.

On a bigger scale though, I'd expect the back button to take you back through the history of previous pages. Being able to go back to the main pages isn't entirely the right experience. Especially since the extensions page now has ways to navigate to other profile pages. Besides, we can already go back to the parent page by clicking on the breadcrumb item.

[Techypanda]

I noticed that the back button only appears if we're in a subpage. I'd prefer that we have it always be visible, but we change the enabled/disabled state appropriately.

I was trying to keep it consistent to Windows UI but just realised you are totally right, 'Settings' always has the back button visible, will set to visible and just use Enable/Disable

On a bigger scale though, I'd expect the back button to take you back through the history of previous pages. Being able to go back to the main pages isn't entirely the right experience. Especially since the extensions page now has ways to navigate to other profile pages. Besides, we can already go back to the parent page by clicking on the breadcrumb item.

Thanks good point, i'll do a refactor to try and do this, need to wrap my head around of if there's a 'history' or something i can utilize here to get the right tag :)

Besides, we can already go back to the parent page by clicking on the breadcrumb item.

This was discussed in original issue, the reasoning that you would still have a back button is mainly consistency with what windows ui does (the settings example in issue is great).
Agree on history though ill look into it

[Techypanda]

Going to convert back to draft as I am very lost on how to keep breadcrumbs currently, need to somehow retrieve 'tag' from the Backstack but this information is not pushed

[Techypanda]

Going to close this PR as this approach will not work; I believe you would need to modify the data that is being pushed onto the Backstack so that you can maintain what tags are needed to calculate the breadcrumbs.

Alternatively i guess you could copy the breadcrumbs to a variable and save that in the backstack but I feel like this is not very memory efficient

[DHowett]

However it ends up shaking out, we're excited to see! :)