Fix overrides of negative reviewer/moderator actions for add-ons

[diox]

Fixes mozilla/addons#15653

This fixes overrides of negative actions but also remove the ability to override a decision about an add-on in second level approval (they remain available for other kind of content) - you have to use the review page (or Cinder) to make a new decision about add-ons.

Testing

This is the full testing QA should do. I don't expect a reviewer to do all of that.

Overrides in general

• Report an [add-on, collection, user, rating] publicly available on AMO frontend for a reason like hateful content. Avoid content that would trigger 2nd level approval. For add-ons, specify that the location is on the page and not inside the add-on and don't pick a promoted one. For users/collections/ratings, pick content not tied to staff/developers of promoted add-ons.
• Find the report in Cinder, then disable the content
• Make sure the content has been disabled
• Using decisions tab or investigate feature in Cinder to find that decision, override it and approve it instead
• Make sure the content is back up

Second level approval of non add-ons

• Report a [collection, user, rating] publicly available on AMO frontend for a reason like hateful content. We want to trigger 2nd level approval, so when picking/creating the relevant content, the collection should be owned by the TASK_USER_ID user, the user should be a staff user or someone who is an author of add-ons belonging to a high-profile promoted group, the rating should be a developer reply on an add-ons belonging to a high-profile promoted group.
• Find the report in Cinder, then disable the content
• Make sure the decision is held for 2nd level approval
• In second level approval, find that decision and note that you can either approve the content instead of proceeding with the decision
• Test that both options work

Second level approval of add-ons

• Report an add-on publicly available on AMO for violating policies in the add-on. Pick an add-on that would trigger 2nd level approval, such as a recommended add-on.
• In reviewer tools, disable the add-on, or reject its versions
• Make sure that decision is held for 2nd level approval
• In second level approval, find that decision and note that you can no longer approve the content instead, but only proceed with the decision or enqueue the add-on back in reviewer tools.
• Test that both options work

[eviljeff]

A developer can't appeal a delayed rejection - if it's not cancelled by a reviewer it's followed by a rejection, that they can appeal.
(And an override can't come from Cinder of delayed rejection, because it's only emitted by reviewer tools)

... right? Am I missing some case?

[eviljeff]

Or is it this to fix a 2nd level approval action? Can you detail the scenario?

[diox]

You're right - I just wanted that to work in case 2nd level approval was ever allowed to "approve content instead" again for add-ons (when I started working on this, I was going to let 2nd level approvers continue to use that in some cases).