Skip to content

remove Fakespot from advertising pages (fix #16358) #16364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 1, 2025

Conversation

wen-2018
Copy link
Collaborator

@wen-2018 wen-2018 commented Jun 26, 2025

If this changeset needs to go into the FXC codebase, please add the WMO and FXC label.

One-line summary

This PR removes Fakespot from advertising pages.

Significant changes and points to review

/advertising
/advertising/formats
drop firefox/welcome/18 page

Issue / Bugzilla link

#16359

Testing

http://localhost:8000/en-US/advertising/
http://localhost:8000/en-US/advertising/formats/
http://localhost:8000/en-US/firefox/welcome/18/

@wen-2018 wen-2018 requested a review from a team as a code owner June 26, 2025 13:59
@wen-2018 wen-2018 added Needs Review Awaiting code review Frontend HTML, CSS, JS... client side stuff WMO and FXC Code relevant to both the WMO and FXC projects labels Jun 26, 2025
@wen-2018 wen-2018 requested a review from a team as a code owner June 26, 2025 15:22
Copy link
Contributor

@stevejalim stevejalim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tried locally with a Prod-mode build of the assets and it's fine

r+

@stevejalim stevejalim merged commit b2be945 into mozilla:main Jul 1, 2025
6 checks passed
@stevejalim stevejalim deleted the remove-fakespot-2 branch July 1, 2025 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Frontend HTML, CSS, JS... client side stuff Needs Review Awaiting code review WMO and FXC Code relevant to both the WMO and FXC projects
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants