iCalendar Duration RFC Compliance Fix #108
Open
+157
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o synchronization errors. We have modified the toString function in ical.sys.mjs to ensure RFC compliant duration, and prevent synchronization errors. We have also added a test suite for this modification to ensure correct behavior.
|
If someone could review this PR / our modification when they get a chance, that would be great. Thank you! |
|
This repo is just a read only mirror with the source being https://hg.mozilla.org/comm-central/ . In this case though, for ical.js which you're modifying, the upstream for that is pulled in from https://github.com/kewisch/ical.js. Can you file an issue and submit a PR there instead? |
|
Looks like someone created an issue for it back in July, I'll reference that in the pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, duration was not compliant with RFC Guidelines, leading to synchronization errors. We have modified the toString function in ical.sys.mjs to ensure RFC compliant duration, and prevent synchronization errors. We have also added a test suite for this modification to ensure correct behavior.
Issue Link: #103