Skip to content

Optimize testing assertions #15002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Optimize testing assertions #15002

wants to merge 1 commit into from

Conversation

alexknop
Copy link
Collaborator

Found a couple of optimizations to make in testing:

  1. Flip assertEquals arguments to expected followed by provided
  2. Leverage assertArrayEquals

@alexknop
optimize testing assertions
2eb1263 
Signed-off-by: Alex Knop <knopalex@msu.edu>
@alexknop alexknop force-pushed the testingOptimizations branch from ab615f4 to 2eb1263 Compare June 18, 2025 20:14
@github-actions GitHub Actions
Copy link

blue-Light-Screenshot test failed, but no output was generated. Maybe a preliminary stage failed.

@github-actions GitHub Actions
Copy link

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/15002.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@alexknop