Enabled the use of non-transitive R classes. #15041
Conversation
eeshanjamal
commented
Jun 20, 2025
eeshanjamal
commented
- Tests not needed.
- Do check my TODO comments when reviewing the pull request.
Signed-off-by: Eeshan Jamal <eeshan.jamal@gmail.com>
| @@ -16,7 +16,8 @@ enum class QuickPermissionType( | |||
| val iconId: Int, | |||
| val textId: Int | |||
| ) { | |||
| NONE(R.drawable.ic_unknown, R.string.unknown), | |||
| //TODO: R.string.unknown resource referenced from osmdroid library. Ideally it should be part of this app resource. | |||
| NONE(R.drawable.ic_unknown, org.osmdroid.library.R.string.unknown), | |||
There was a problem hiding this comment.
Hm. Maybe it better to create the string then within our values.xml?
There was a problem hiding this comment.
Yeah! I was actually thinking to add one in values.xml but I was not sure about localization handling. Does it automatically handled by Transifex once added?
| primaryColor = | ||
| colorUtil.getNullSafeColorWithFallbackRes(capability.serverColor, R.color.colorPrimary) | ||
| colorUtil.getNullSafeColorWithFallbackRes(capability.serverColor, com.blikoon.qrcodescanner.R.color.colorPrimary) |
There was a problem hiding this comment.
Fallback should then be our primary color:
values.xml -> primary
There was a problem hiding this comment.
See com.owncloud.android.R.color.primary.
There was a problem hiding this comment.
Noted! Let me replace it.
|
Dear @eeshanjamal, thank you for taking care of the migration to use non-transitive R classes throughout our app. So far these changes look good. Tobias and I have added some comments which we would like you to address. Due to our security policies, we do not allow our CI tests to run on forks of our repositories. As a result the Analysis step of our pipeline will always fail in this pull request, which one can also see in the actions log. In order to resolve this issue, we would like to invite you to our GitHub organisation. This will enable you to reopen this pull request and open future ones directly from branches within the relevant repositories. Please let us know if this is OK for you. |
|
@ZetaTom Yeah! sure, It's fine. Would be bit easier for me as well to manage the branching & pull request. Thanks 👍 |
I added you to our team. You will soon receive an invitation. |
|
Closing this pull request and going to create another one from upstream repo along with the additional changes. |
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
