BugFix - Fix Toolbar Inconsistency For Favorites Tab #15049
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
alperozturk96
force-pushed
the
bugfix/hide-home-search-toolbar-and-sort-list-button-for-favorites
branch
from
28419b0 to
fafb061
Compare
Seems like okay. Screen.Recording.2025-06-27.at.10.33.01.mp4 |
alperozturk96
added
the
ux-enhancement
tobiasKaminsky
force-pushed
the
bugfix/hide-home-search-toolbar-and-sort-list-button-for-favorites
branch
from
fafb061 to
ea10b74
Compare
|
/backport to stable-3.32 |
ZetaTom
requested changes
Jul 9, 2025
There was a problem hiding this comment.
During our review meeting, @alperozturk96 and I found the following inconsistencies:
- unified search bar still appears
- Open Nextcloud App
- (Add folder to favourites, only if no favourites are set)
- Open Favourites tab
- Open folder from second step
- Press back button
- Wrong search bar appears
- wrong title in search bar
- Repeat steps above
- Lock device
- Unlock device
- Favourites is replaced with instance name ("Devcloud" in my case)
Signed-off-by: alperozturk <alper_ozturk@proton.me>
alperozturk96
force-pushed
the
bugfix/hide-home-search-toolbar-and-sort-list-button-for-favorites
branch
from
ea10b74 to
79f12dd
Compare
|
blue-Light-Screenshot test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/15049-Screenshot-blue-Light-08-52 |
|
APK file: https://www.kaminsky.me/nc-dev/android-artifacts/15049.apk |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Favorites toolbar is inconsistent when switching between screens.
How to reproduce:
Before
before.mp4
After
after.mp4