fix(maintenance): refresh page when turned off (sometimes) #53528
+1
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Josh <josh.t.richards@gmail.com>
joshtrichards
requested review from
nfebe and
skjnldsv
and removed request for
a team
joshtrichards
added
3. to review
|
/backport to stable31 |
|
/backport to stable30 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We claim on the user-facing maintenance page that it'll automatically refresh when service is restored. However the JS-based watcher wasn't loading because depends on
common1.Not sure how long this was broken for, but probably going back at least several majors (maybe more).
Still only a partial solution to the broader problem, but addresses the scenario that occurs when toggling maintenance mode during operations that do not use the built-in Updater2.
Follow-up ideas:
Footnotes
Since the maintenance page is "special" (and relatively simple) we should/could probably eliminate it's dependence on
common. Of course the maintenance page is still stuck with styling dependencies... See next item. ↩During normal operations, toggling maintenance mode on/off will work (and refresh automatically with this PR), but when using the standard Updater presumably it'll break due to both a loss of styling and Javascript asset access. This is because in the Updater we replace the entry points as an intermediate step. Directly related to Plain maintenance mode page #5789. Also, somewhat related to, Allow communicating expectations to users during maintenance #35787. ↩