Skip to content

fix(files_reminders): Join the reminders with the file system metadata #53548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 23, 2025

Conversation

solracsf
Copy link
Member

@solracsf solracsf commented Jun 17, 2025

Eliminates the need to load fileIds into PHP by using a database INNER JOIN with the oc_filecache table, filtering files by their parent (the folder's ID) directly in the SQL query. This avoids the IN clause entirely

Checklist

…a table

Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
Copy link
Member

@provokateurin provokateurin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this looks much better and should fix #53527

@provokateurin
Copy link
Member

@solracsf any reason to keep it as a draft?

@solracsf
Copy link
Member Author

I'll be on holiday for the next 3 weeks, but feel free to open/review.

@provokateurin provokateurin marked this pull request as ready for review June 23, 2025 07:48
@provokateurin provokateurin requested a review from a team as a code owner June 23, 2025 07:48
@provokateurin provokateurin requested review from ArtificialOwl, icewind1991 and Altahrim and removed request for a team June 23, 2025 07:48
@provokateurin
Copy link
Member

/backport to stable31

@provokateurin
Copy link
Member

/backport to stable30

@come-nc come-nc merged commit f980d94 into master Jun 23, 2025
202 of 204 checks passed
@come-nc come-nc deleted the fixFilesRemindersJoins branch June 23, 2025 10:24
Copy link

backportbot bot commented Jun 23, 2025

The backport to stable30 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable30
git pull origin stable30

# Create the new backport branch
git checkout -b backport/53548/stable30

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 4eb357e9

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/53548/stable30

Error: Failed to check for changes with origin/stable30: No changes found in backport branch


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@provokateurin
Copy link
Member

The stable30 backport must also include #53644!

@solracsf
Copy link
Member Author

The stable30 backport must also include #53644!

findAllInFolder() is v31+

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: More than 1000 expressions in a list are not allowed on Oracle. (postgresql, in files_reminders / cacheFolder)
4 participants