fix: revive always storing lowercased email addresses in AllConfig #53615
Conversation
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
|
/backport to stable31 |
|
/backport to stable30 |
st3iny
added
3. to review
st3iny
requested review from
ArtificialOwl,
Altahrim,
provokateurin,
nickvergessen and
juliusknorr
and removed request for
a team
| @@ -253,6 +253,10 @@ public function setUserValue($userId, $appName, $key, $value, $preCondition = nu | |||
| } | |||
| } | |||
|
|
|||
| if ($appName === 'settings' && $key === 'email') { | |||
There was a problem hiding this comment.
should add to UserConfig as well as it otherwise simply breaks again.
I'd also suggest to change the existing or add another integration test to
server/build/integration/features/provisioning-v1.feature
Lines 128 to 142 in 6254354
which sets it as camel case and afterwards confirms it's lower case with:
server/build/integration/features/provisioning-v1.feature
Lines 163 to 171 in 6254354
There was a problem hiding this comment.
Move the entire if condition to UserConfig or just duplicate it there?
There was a problem hiding this comment.
well if one place calls the other, the lower one needs to have it. if both write directly to DB, both need it.
There was a problem hiding this comment.
Basically coming from the question, when UserConfig is started being used, will we have the same bug again
st3iny
added
2. developing
|
@nickvergessen might be cool to have: #53619 |
outboxcollection always returns3.7;Could not find principal#50239 (comment)Summary
This fix was first implemented in #30197 but got lost.
Before: Mixed case emails (from LDAP) are saved as is in
oc_preferences.After: Mixed case emails are saved in lowercase in
oc_preferences.TODO
Checklist