Skip to content

fixes #24996; Crash on marking destroy hook as .error #25002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 16, 2025
Merged

fixes #24996; Crash on marking destroy hook as .error #25002

merged 2 commits into from
Jun 16, 2025

Conversation

ringabout
Copy link
Member

fixes #24996

uses the lineinfos of dest is ri is not available (e.g. =destroy doesn't have a second parameter)

@Araq Araq added the merge_when_passes_CI mergeable once green label Jun 16, 2025
@Araq Araq merged commit c22bfe6 into devel Jun 16, 2025
18 checks passed
@Araq Araq deleted the pr_err branch June 16, 2025 19:50
@github-actions GitHub Actions
Copy link
Contributor

Thanks for your hard work on this PR!
The lines below are statistics of the Nim compiler built from c22bfe6

Hint: mm: orc; opt: speed; options: -d:release
182725 lines; 8.720s; 659.352MiB peakmem

narimiran pushed a commit that referenced this pull request Jun 16, 2025
@ringabout @narimiran
fixes #24996; Crash on marking destroy hook as .error (#25002)
1f205a0 
fixes #24996

uses the lineinfos of `dest` is `ri` is not available (e.g. `=destroy`
doesn't have a second parameter)

(cherry picked from commit c22bfe6)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
merge_when_passes_CI mergeable once green
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Crash on marking destroy hook as .error
2 participants
@ringabout @Araq