Skip to content

Add support for arm64 on linux #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

kraptor
Copy link

@kraptor kraptor commented Nov 7, 2024

Hello @ringabout,

following the changes for #54 and following how Crystal does it, this is an attempt to add support for Linux ARM64 (you may want to use aarch64 instead, as you wish, but Asahi linux identifies itself as linux_arm64 so I think you may want to support both?).

In order to this PR to work, you need to request credits to ARM itself by opening an issue, but as far as I see, it should be fine as Nim is fully opensource.

Unfortunately, you need to discuss details with them directly via email, as I'm not officially part of the Nim "organization" (probably you will be contacted by @shipra-ps, maybe they can help in here directly?).

You may need to supply the github.run_id they provide and adapt/play a bit with the CI yaml, but I hope this is a kickstart.

Thanks!

@kraptor
Copy link
Author

kraptor commented Nov 7, 2024

Related to #23

@veaceslavdoina
Copy link

@ringabout, is there any progress on that?

@kraptor, GitHub recently announced Linux arm64 hosted runners now available for free in public repositories (Public Preview) and we can switch to the native arm runners

  • ubuntu-22.04-arm
  • ubuntu-24.04-arm

@shipra-ps
Copy link

Hi Team,
Now Linux arm64 hosted runners are available for free in public repositories. You may check the attached link for your reference https://github.blog/changelog/2025-01-16-linux-arm64-hosted-runners-now-available-for-free-in-public-repositories-public-preview/

runs-on: ubuntu-22.04-arm
steps:
- uses: actions/checkout@v4
- uses: jiro4989/setup-nim-action@v2
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't seem to support linux arm64

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we use devel option?

    runs-on: ubuntu-22.04-arm64
    steps:
      - uses: jiro4989/setup-nim-action@v2
        with:
          nim-version: devel
          repo-token: ${{ secrets.GITHUB_TOKEN }}
nim -v

Nim Compiler Version 2.3.1 [Linux: arm64]
Compiled at 2025-02-11
Copyright (c) 2006-2025 by Andreas Rumpf
git hash: 1a7bc6d878ff04709ebb1002010fd53b4ba02179
active boot switches: -d:release
nimble -v

nimble v0.16.4 compiled at 2025-02-11 11:17:21
git hash: 123f97a5e4ee9ba35720c0869e19a047c43c797e

@ringabout
Copy link
Member

ringabout commented Feb 11, 2025

Download links should be adapted to arm64 as well. e.g.

if "x" & $arch in aname:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants