-
Notifications
You must be signed in to change notification settings - Fork 10
Add support for arm64 on linux #60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Related to #23 |
@ringabout, is there any progress on that? @kraptor, GitHub recently announced Linux arm64 hosted runners now available for free in public repositories (Public Preview) and we can switch to the native arm runners
|
Hi Team, |
runs-on: ubuntu-22.04-arm | ||
steps: | ||
- uses: actions/checkout@v4 | ||
- uses: jiro4989/setup-nim-action@v2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It doesn't seem to support linux arm64
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we use devel
option?
runs-on: ubuntu-22.04-arm64
steps:
- uses: jiro4989/setup-nim-action@v2
with:
nim-version: devel
repo-token: ${{ secrets.GITHUB_TOKEN }}
nim -v
Nim Compiler Version 2.3.1 [Linux: arm64]
Compiled at 2025-02-11
Copyright (c) 2006-2025 by Andreas Rumpf
git hash: 1a7bc6d878ff04709ebb1002010fd53b4ba02179
active boot switches: -d:release
nimble -v
nimble v0.16.4 compiled at 2025-02-11 11:17:21
git hash: 123f97a5e4ee9ba35720c0869e19a047c43c797e
Download links should be adapted to arm64 as well. e.g. choosenim/src/choosenimpkg/download.nim Line 46 in 9b47975
|
Hello @ringabout,
following the changes for #54 and following how Crystal does it, this is an attempt to add support for Linux ARM64 (you may want to use aarch64 instead, as you wish, but Asahi linux identifies itself as
linux_arm64
so I think you may want to support both?).In order to this PR to work, you need to request credits to ARM itself by opening an issue, but as far as I see, it should be fine as Nim is fully opensource.
Unfortunately, you need to discuss details with them directly via email, as I'm not officially part of the Nim "organization" (probably you will be contacted by @shipra-ps, maybe they can help in here directly?).
You may need to supply the
github.run_id
they provide and adapt/play a bit with the CI yaml, but I hope this is a kickstart.Thanks!