Skip to content

feat(Table): add footer support to display column summary #4194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking β€œSign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 21 commits into from
Jul 2, 2025

Conversation

gigor
Copy link
Contributor

@gigor gigor commented May 20, 2025 β€’

πŸ”— Linked issue

Resolves: #1025

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

This change enables the display of the table footer for any column.

It checks if any column definition includes a footer key, and if so, renders a element using TanStack Table’s getFooterGroups().

A new sticky-footer prop allows the footer to be fixed in place when scrolling. Footer columns can also be pinned.

Additional CSS removes padding from empty cells, so if all columns with footers are hidden, the footer won’t appear visuallyβ€”even if it is rendered in the DOM.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@gigor gigor marked this pull request as ready for review May 20, 2025 16:40
Copy link

pkg-pr-new bot commented May 20, 2025 β€’

npm i https://pkg.pr.new/@nuxt/ui@4194

commit: ba180a1

@gigor
Copy link
Contributor Author

gigor commented May 27, 2025

@benjamincanac can you please have a look? I will update docs if the implementation is good enough.

@benjamincanac benjamincanac changed the title feat(table) Adds table footer to display column summary feat(Table): add footer support to display column summary May 30, 2025
@gigor
Copy link
Contributor Author

gigor commented Jun 10, 2025

@benjamincanac anything else you think needs changing?

@gigor gigor requested a review from benjamincanac June 13, 2025 09:22
@gigor gigor requested a review from benjamincanac June 13, 2025 14:32
@gigor
Copy link
Contributor Author

gigor commented Jun 26, 2025

Hi @benjamincanac can you please have a look again and approve/reject this pr?

Copy link
Member

@benjamincanac benjamincanac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've updated the code a bit if you want to take a look before I merge it 😊

@gigor
Copy link
Contributor Author

gigor commented Jul 2, 2025

Thanks, looks good to me.

@benjamincanac benjamincanac merged commit c355cac into nuxt:v3 Jul 2, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Footer Feature to Table Component
2 participants