-
Notifications
You must be signed in to change notification settings - Fork 794
feat(Table): add footer
support to display column summary
#4194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking βSign up for GitHubβ, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
commit: |
@benjamincanac can you please have a look? I will update docs if the implementation is good enough. |
footer
support to display column summary
@benjamincanac anything else you think needs changing? |
Hi @benjamincanac can you please have a look again and approve/reject this pr? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've updated the code a bit if you want to take a look before I merge it π
Thanks, looks good to me. |
π Linked issue
Resolves: #1025
β Type of change
π Description
This change enables the display of the table footer for any column.
It checks if any column definition includes a footer key, and if so, renders a element using TanStack Tableβs getFooterGroups().
A new sticky-footer prop allows the footer to be fixed in place when scrolling. Footer columns can also be pinned.
Additional CSS removes padding from empty cells, so if all columns with footers are hidden, the footer wonβt appear visuallyβeven if it is rendered in the DOM.
π Checklist